Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check that compiled scripts are consistent. #30

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

choener
Copy link
Collaborator

@choener choener commented Dec 30, 2024

  • Could be its own job, but convenient to run during main linux CI.

Currently, I just run the consistency check at the end of the build pipeline, which is very cheap. Right now, the scripts /are/ actually inconsistent, which is why the test fails.

@choener choener linked an issue Dec 30, 2024 that may be closed by this pull request
@choener choener force-pushed the 10-ci-check-that-the-compiled-scripts-havent-changed branch from 498c3ce to 8b95663 Compare December 30, 2024 15:17
@choener choener requested a review from j-mueller December 30, 2024 15:28
Copy link
Collaborator

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@choener choener merged commit 082d3a4 into main Jan 2, 2025
2 of 7 checks passed
@choener choener deleted the 10-ci-check-that-the-compiled-scripts-havent-changed branch January 2, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Check that the compiled scripts haven't changed
2 participants