Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafted section on threat vectors #96

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Drafted section on threat vectors #96

merged 2 commits into from
Dec 13, 2024

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Dec 10, 2024

See docs/technical-report-1.md#threat-model for the discussion of the threat model.

Questions for reviewers:

  • Should this be a narrative or a table?
  • Do we need more details for the threats?
  • Is it worth including already fully or partially mitigated threats, just for completeness and because we'll need to discuss them in the CIP?
  • What's missing?

@bwbush bwbush self-assigned this Dec 10, 2024
docs/technical-report-1.md Outdated Show resolved Hide resolved
docs/technical-report-1.md Outdated Show resolved Hide resolved
@will-break-it
Copy link
Contributor

will-break-it commented Dec 11, 2024

Great overview. I haven't found anything that's missing.
Perhaps, it does make sense to split the threats that haven't been addresses and require further research from the ones already considered/ potentially solved.

Another improvement could be splitting threats into multiple tables by category, like the ones you've already mentioned:
by delay, invalid creation, equivocation, grinding...

@bwbush
Copy link
Collaborator Author

bwbush commented Dec 13, 2024

Great overview. I haven't found anything that's missing. Perhaps, it does make sense to split the threats that haven't been addresses and require further research from the ones already considered/ potentially solved.

Another improvement could be splitting threats into multiple tables by category, like the ones you've already mentioned: by delay, invalid creation, equivocation, grinding...

I split the tables by subject and then later summarized what was outstanding. This seemed to flow better. Fixed in 93233d9.

@bwbush bwbush merged commit b586ca9 into main Dec 13, 2024
7 checks passed
@bwbush bwbush deleted the bwbush/tr-thread branch December 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants