simulation: integrated unbounded parallelism worker thread #614
Annotations
1 error and 10 warnings
🛠️ Run HLint
HLint failed with status: 1. Warning (7), Suggestion (3)
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/TaskMultiQueue.hs#L2
Warning in module LeiosProtocol.TaskMultiQueue: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE DeriveFunctor #-}"
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/TaskMultiQueue.hs#L5
Warning in module LeiosProtocol.TaskMultiQueue: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE OverloadedRecordDot #-}"
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/TaskMultiQueue.hs#L7
Warning in module LeiosProtocol.TaskMultiQueue: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE StandaloneDeriving #-}"
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/TaskMultiQueue.hs#L32
Warning in writeTMQueue in module LeiosProtocol.TaskMultiQueue: Eta reduce ▫︎ Found: "writeTMQueue (TaskMultiQueue mq) lbl task\n = writeTBQueue (mq ! lbl) task" ▫︎ Perhaps: "writeTMQueue (TaskMultiQueue mq) lbl = writeTBQueue (mq ! lbl)"
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/TaskMultiQueue.hs#L48
Warning in runInfParallelBlocking in module LeiosProtocol.TaskMultiQueue: Use concatMap ▫︎ Found: "concat . map snd" ▫︎ Perhaps: "concatMap snd"
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/Short/Node.hs#L466
Suggestion in dispatchValidation in module LeiosProtocol.Short.Node: Redundant $ ▫︎ Found: "Map.fromList $ [(eb.id, Set.fromList eb.inputBlocks Set.\\\\ ibs)]" ▫︎ Perhaps: "Map.fromList [(eb.id, Set.fromList eb.inputBlocks Set.\\\\ ibs)]"
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/Short/VizSim.hs#L232
Suggestion in LeiosModelConfig in module LeiosProtocol.Short.VizSim: Use newtype instead of data ▫︎ Found: "data LeiosModelConfig = LeiosModelConfig {recentSpan :: DiffTime}" ▫︎ Perhaps: "newtype LeiosModelConfig\n = LeiosModelConfig {recentSpan :: DiffTime}" ▫︎ Note: decreases laziness
|
🛠️ Run HLint:
simulation/src/LeiosProtocol/Short/VizSimP2P.hs#L100
Suggestion in messageLegend in module LeiosProtocol.Short.VizSimP2P: Move brackets to avoid $ ▫︎ Found: "d `Dia.atop`\n (Dia.fc Dia.white\n $ Dia.lc Dia.white\n $ Dia.rect (Dia.width d + 20 * 12) (Dia.height d))" ▫︎ Perhaps: "d `Dia.atop`\n Dia.fc\n Dia.white\n (Dia.lc Dia.white\n $ Dia.rect (Dia.width d + 20 * 12) (Dia.height d))"
|
🛠️ Run HLint:
simulation/src/PraosProtocol/ChainSync.hs#L1
Warning in module PraosProtocol.ChainSync: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE BangPatterns #-}"
|
🛠️ Run HLint:
simulation/src/PraosProtocol/ChainSync.hs#L9
Warning in module PraosProtocol.ChainSync: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE OverloadedRecordDot #-}"
|
Loading