Threat model analysis and blog post review PR

[oduameh]

Content

This PR includes...

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

[jpraynaud]

@oduameh I left few comments below.

Also, could you:

• synchronize your fork so that we can fix some conflicts on the branch
• sign your commits as explained here (otherwise we can't merge the PR)

[olgahryniuk]

@oduameh, please address JP's review suggestions. Particularly, I believe we want network names to be lowercase (eg, release-preprod instead of Release-preprod). I made some more edits directly.

[oduameh]

Hi @jpraynaud I just addressed the issues you raised just working on signing the commit

[jpraynaud]

Hi @jpraynaud I just addressed the issues you raised just working on signing the commit

Hi @oduameh, thanks! No need to repush the branch as I handled to sign them this time. But for the next PR you will need to sign the commits.

Also, I have given you write rights on the repository, so you can create a branch on the repository without going through your fork (which will simplify the process of merging) 👍

[oduameh]

Hi @jpraynaud I just addressed the issues you raised just working on signing the commit

Hi @oduameh, thanks! No need to repush the branch as I handled to sign them this time. But for the next PR you will need to sign the commits.

Also, I have given you write rights on the repository, so you can create a branch on the repository without going through your fork (which will simplify the process of merging) 👍

Thanks @jpraynaud