Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement CardanoDatabase artifact routes #2187

Merged
merged 24 commits into from
Dec 20, 2024
Merged

Feat: implement CardanoDatabase artifact routes #2187

merged 24 commits into from
Dec 20, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 18, 2024 •
edited
Loading

Content

This PR includes the implementation of the artifact routes for the CardanoDatabase signed entity type.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2152

@jpraynaud jpraynaud self-assigned this Dec 18, 2024
@jpraynaud
feat: add conversion from 'SignedEntityRecord' to 'CardanoDatabaseSna…
07825c7 
…pshotMessage' and 'CardanoDatabaseSnapshotListItemMessage'
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Test Results

    4 files  ± 0     52 suites  ±0   10m 35s ⏱️ +16s
1 460 tests +12  1 460 ✅ +12  0 💤 ±0  0 ❌ ±0 
1 716 runs  +12  1 716 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 57efde6. ± Comparison against base commit 6cb9d30.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from fc72970 to a91d12f Compare December 18, 2024 17:41
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 18, 2024 17:54 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 19, 2024 08:49 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from a91d12f to 0ae9c39 Compare December 19, 2024 12:12
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 19, 2024 12:25 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review December 19, 2024 12:31
dlachaume
dlachaume approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-common/src/messages/cardano_database_list.rs Outdated Show resolved Hide resolved
mithril-common/src/messages/cardano_database_list.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/services/message.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs Outdated Show resolved Hide resolved
mithril-test-lab/mithril-end-to-end/src/end_to_end_spec.rs Show resolved Hide resolved
sfauvel
sfauvel approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Some remarks to simplify reading the code

mithril-aggregator/src/artifact_builder/cardano_database.rs Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs Show resolved Hide resolved
mithril-aggregator/src/services/message.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/services/message.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/services/signed_entity.rs Outdated Show resolved Hide resolved
mithril-test-lab/mithril-end-to-end/src/assertions/check.rs Show resolved Hide resolved
mithril-test-lab/mithril-end-to-end/src/assertions/check.rs Show resolved Hide resolved
Alenar
Alenar approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if the new parameter could be avoided.

mithril-aggregator/src/http_server/routes/artifact_routes/snapshot.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/messages/cardano_database_list.rs Outdated Show resolved Hide resolved
mithril-common/src/messages/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/messages/cardano_database_list.rs Show resolved Hide resolved
mithril-common/src/messages/cardano_database.rs Show resolved Hide resolved
mithril-common/src/messages/message_parts/signed_entity_type_message.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/configuration.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from 0ae9c39 to b4093cc Compare December 20, 2024 12:14
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 20, 2024 13:22 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch 2 times, most recently from d4792e2 to dc45eac Compare December 20, 2024 14:46
@jpraynaud
refactor: make e2e tests assertions more readable
6132903
@jpraynaud
docs: update CHANGELOG
f369ef3
@jpraynaud
chore: upgrade crates versions and openapi.yaml version
57efde6 
* mithril-aggregator from '0.6.4' to '0.6.5'
* mithril-common from '0.4.97' to '0.4.98'
* mithril-end-to-end from '0.4.55' to '0.4.56'
* openapi.yaml from '0.1.38' to '0.1.39'
@jpraynaud jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from dc45eac to 57efde6 Compare December 20, 2024 14:57
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 20, 2024 15:19 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit d3e21fb into main Dec 20, 2024
53 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2152-cardano-db-artifact-routes branch December 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement artifact routes for Incremental Cardano DB in aggregator REST API
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume