Build and publish an unstable explorer version #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/2172/unstable-explorer
branch
from
61730fb to
d7d7789
Compare
That can be toogled on by setting a `UNSTABLE` environment variable to `1` when building developer or production builds.
Using a `BASE_PATH` env var. Reminder: the base path is notably added to all intra-links generated by the router.
In `/explorer/unstable`
Alenar
force-pushed
the
djo/2172/unstable-explorer
branch
from
d7d7789 to
52b7107
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a 'Unstable' feature flag to the explorer, toggled by setting a
UNSTABLEenvironment variable to1at compile time.This, alongside another change that allow to parametrize the explorer base path (to have correct intra links), allow us to have two published version of the explorer:
https://mithril.network/explorer/: that will use the packaged version of the explorer from the last stable release, built withunstablefeature disabled ( ⚒️ coming soon, see comments).https://mithril.network/explorer/unstable: that will use the latest code from themainbranch, build withunstablefeatures enabled.Pre-submit checklist
Comments
This does not finish #2172 as we need to wait for a new release to have a packaged "stable" explorer build that can be retrieved each time we publish to github pages.
In the meantime we will keep using the
mainbranch code for the published "stable" version but with the unstable features disabled.Issue(s)
Relates to #2172