Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement the Ancillary sub builder for Incremental Cardano DB #2180

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Feat: implement the Ancillary sub builder for Incremental Cardano DB #2180

merged 9 commits into from
Dec 17, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Dec 16, 2024 •
edited
Loading

Content

This PR includes the first implementation of the ancillary builder for the Incremental Cardano Database.

It handles the upload of ancillary artifacts using a Local Uploader and adds the returned locations to the CardanoDatabaseSnapshot. The creation and verification of the ancillary archive will be handled in a separate PR.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #2151

@dlachaume dlachaume changed the title Feat: implement Ancillary sub builder for Incremental Cardano DB Feat: implement the Ancillary sub builder for Incremental Cardano DB Dec 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   9m 57s ⏱️ +4s
1 432 tests +4  1 432 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 643 runs  +4  1 643 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 32d1ef4. ± Comparison against base commit 06e7e43.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet December 16, 2024 17:40 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the ensemble/2151/implement-sub-builders branch from 22e0851 to ba848e2 Compare December 17, 2024 10:11
@dlachaume dlachaume marked this pull request as ready for review December 17, 2024 10:14
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 17, 2024 10:20 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/dependency_injection/builder.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 17, 2024 11:42 — with GitHub Actions Inactive
dlachaume and others added 7 commits December 17, 2024 16:37
@dlachaume @sfauvel
feat: implement AncillaryArtifactBuilder sub-builder
1ef5dce 
Co-authored-by: Sébastien Fauvel <[email protected]>
@dlachaume
feat: add the AncillaryArtifactBuilder dependency to the cardano da…
4fec95b 
…tabase artifact builder
@dlachaume @sfauvel
refactor: extract CardanoDatabaseArtifactBuilder creation in the ag…
156cee0 
…gregator dependency builder

Co-authored-by: Sébastien Fauvel <[email protected]>
@dlachaume
refactor: enhance namings in the ancillary module
9501035 
- remove useless `Aggregator` reference in the `AncillaryFileUploader` trait name
- rename ancillary builder unit test to reflect `upload_archive` behavior
@dlachaume
refactor: add documentation, renaming and test enhancement
7db78d6
@dlachaume @sfauvel
fix: remove the use of the ancillary builder in `CardanoDatabaseArtif…
fe1f710 
…actBuilder`

Co-authored-by: Sébastien Fauvel <[email protected]>
@dlachaume
test: ensure upload with LocalUploader error if the provided path i…
9d8d639 
…s a directory
@dlachaume dlachaume force-pushed the ensemble/2151/implement-sub-builders branch 2 times, most recently from 2cd02c2 to 7736c7f Compare December 17, 2024 15:46
jpraynaud
jpraynaud approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-aggregator/src/configuration.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/dependency_injection/builder.rs Outdated Show resolved Hide resolved
@dlachaume
fix: ensure that the snapshot directory and the cardano database arti…
5f20bd7 
…facts directory are properly created
@dlachaume
chore: upgrade crate versions
32d1ef4 
* mithril-aggregator from `0.6.3` to `0.6.4`
* mithril-common from `0.4.96` to `0.4.97`
@dlachaume dlachaume force-pushed the ensemble/2151/implement-sub-builders branch from 7736c7f to 32d1ef4 Compare December 17, 2024 16:03
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 17, 2024 16:20 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 05cdbea into main Dec 17, 2024
51 of 54 checks passed
@dlachaume dlachaume deleted the ensemble/2151/implement-sub-builders branch December 17, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel left review comments

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud