Get rid of store adapter in signer

[sfauvel]

Content

Replace the store using the legacy store adapter and replace them with a repository implementation in the Signer.

This PR includes:

• a refactoring of ConnectionBuilder to be able to execute partial migrations.
• the creation of protocol_initializer_repository et stake_pool_store and associated queries and records.
• tests on data migration from adapter table to the new structure.
• the removal of all references to ̀adapter` module
• the creation of a tests module in database to test repository behavior

Warning

The migration number for signed_beacon was fixed (4 instead of 31). That need to manually update db_version just before merging this PR.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)

Comments

• To test migration, a FakeAdapter was created to initialize database like the StoreAdapter did but without depending on it.
• The 'map-err' has been removed from the 'stake' compared to what is in the aggregator to remove the dependency on adapter module.

Issue(s)

Relates to #2118

[github-actions]

Test Results

    4 files  ±0     51 suites  ±0   11m 38s ⏱️ -19s
1 455 tests +9  1 455 ✅ +9  0 💤 ±0  0 ❌ ±0 
1 666 runs  +9  1 666 ✅ +9  0 💤 ±0  0 ❌ ±0 

Results for commit a14746c. ± Comparison against base commit 0b8564c.

This pull request removes 12 and adds 21 tests. Note that renamed tests count towards both.

mithril-signer ‑ store::protocol_initializer_store::tests::check_retention_limit
mithril-signer ‑ store::protocol_initializer_store::tests::get_protocol_initializer_for_empty_epoch
mithril-signer ‑ store::protocol_initializer_store::tests::get_protocol_initializer_for_existing_epoch
mithril-signer ‑ store::protocol_initializer_store::tests::save_key_in_empty_store
mithril-signer ‑ store::protocol_initializer_store::tests::update_protocol_initializer_in_store
mithril-signer ‑ store::stake_store::tests::check_retention_limit
mithril-signer ‑ store::stake_store::tests::get_stakes_for_empty_epoch
mithril-signer ‑ store::stake_store::tests::get_stakes_for_existing_epoch
mithril-signer ‑ store::stake_store::tests::retrieve_returns_stake_distribution
mithril-signer ‑ store::stake_store::tests::retrieve_with_no_stakes_returns_none
…

mithril-persistence ‑ sqlite::connection_builder::tests::test_apply_a_partial_migrations
mithril-signer ‑ database::query::stake_pool::delete_stake_pool::tests::test_prune_below_epoch_threshold
mithril-signer ‑ database::query::stake_pool::get_stake_pool::tests::test_query_sorts_the_return_stake_pool_by_epoch_stack_and_stake_pool_id
mithril-signer ‑ database::query::stake_pool::insert_or_replace_stake_pool::tests::test_update_stakes
mithril-signer ‑ database::tests::protocol_initializer::migration::should_migrate_data_from_adapter
mithril-signer ‑ database::tests::protocol_initializer::pruning::prune_epoch_older_than_threshold
mithril-signer ‑ database::tests::protocol_initializer::pruning::without_threshold_nothing_is_pruned
mithril-signer ‑ database::tests::protocol_initializer::request::get_last_protocol_initializer_return_all_when_too_few_records
mithril-signer ‑ database::tests::protocol_initializer::request::get_last_protocol_initializer_return_last_one_first
mithril-signer ‑ database::tests::protocol_initializer::request::get_protocol_initializer_for_empty_epoch
…

♻️ This comment has been updated with latest results.

[dlachaume]

LGTM 👍

[jpraynaud]

LGTM 👍