Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cardano stake distribution in mithril-client WASM #1887

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Implement Cardano stake distribution in mithril-client WASM #1887

merged 10 commits into from
Aug 14, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Aug 9, 2024 •
edited
Loading

Content

This PR includes new unstable features for the mithril-client WASM library:

  • get_cardano_stake_distribution
  • get_cardano_stake_distribution_by_epoch
  • list_cardano_stake_distributions
  • compute_cardano_stake_distribution_message

A new verification step has been added in www-test, which can be executed through Mithril Client multi-platform test GitHub action.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1881

@dlachaume dlachaume self-assigned this Aug 9, 2024
@dlachaume dlachaume changed the title Implement Cardano stake distribution commands in mithril-client WASM Implement Cardano stake distribution in mithril-client WASM Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

Test Results

    4 files  ± 0     53 suites  ±0   9m 18s ⏱️ -13s
1 242 tests +13  1 242 ✅ +13  0 💤 ±0  0 ❌ ±0 
1 450 runs  +13  1 450 ✅ +13  0 💤 ±0  0 ❌ ±0 

Results for commit 1d6cd99. ± Comparison against base commit dea7b54.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview August 9, 2024 16:39 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 9, 2024 16:39 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1881/implement-cardano-stake-distribution-in-client-wasm branch from d65481d to 8abbd9a Compare August 12, 2024 10:27
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 12, 2024 12:11 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1881/implement-cardano-stake-distribution-in-client-wasm branch from 8abbd9a to 8afa521 Compare August 12, 2024 13:49
@dlachaume dlachaume force-pushed the dlachaume/1881/implement-cardano-stake-distribution-in-client-wasm branch from 8afa521 to 38d7d96 Compare August 12, 2024 14:51
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 12, 2024 15:13 — with GitHub Actions Inactive
@dlachaume
test: add support for `/artifact/cardano-stake-distribution/epoch/:ep…
6549480 
…och` in the fake aggregator

modify build script to create a list of cardano stake distribution epochs
@dlachaume
feat: implement CardanoStakeDistribution features exposed by `mithr…
087a594 
…il-client` crate in the WASM library
@dlachaume dlachaume force-pushed the dlachaume/1881/implement-cardano-stake-distribution-in-client-wasm branch from 38d7d96 to c421319 Compare August 12, 2024 15:25
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 12, 2024 15:33 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1881/implement-cardano-stake-distribution-in-client-wasm branch from c421319 to 42bed9a Compare August 12, 2024 15:53
@dlachaume dlachaume marked this pull request as ready for review August 12, 2024 15:54
@dlachaume dlachaume requested a review from Alenar August 12, 2024 15:54
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 12, 2024 16:01 — with GitHub Actions Inactive
Alenar
Alenar approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

mithril-client-wasm/src/client_wasm.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 13, 2024 16:47 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 13, 2024 17:01 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 7b8579b into main Aug 14, 2024
46 of 47 checks passed
@dlachaume dlachaume deleted the dlachaume/1881/implement-cardano-stake-distribution-in-client-wasm branch August 14, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Cardano Stake Distribution in WASM client
2 participants
@dlachaume @Alenar