Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual workflow step for old snapshot commands availability #1734

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 6, 2024

Content

This PR includes a fix for the manual workflow Mithril Client multi-platform test that removes command compatibility steps due to the removal of the snapshot command.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume dlachaume force-pushed the damien/remove-old-snapshot-command-compatibility branch from 41fcffd to d0876fb Compare June 6, 2024 08:56
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume self-assigned this Jun 6, 2024
@dlachaume dlachaume requested review from Alenar and sfauvel June 6, 2024 09:02
Copy link

github-actions bot commented Jun 6, 2024

Test Results

    3 files  ±0     43 suites  ±0   8m 45s ⏱️ +18s
1 012 tests ±0  1 012 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 110 runs  ±0  1 110 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d0876fb. ± Comparison against base commit 665621d.

@dlachaume dlachaume temporarily deployed to testing-preview June 6, 2024 09:03 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 6, 2024 09:03 — with GitHub Actions Inactive
@dlachaume dlachaume changed the title Remove step with verification for old 'snapshot' commands availability Remove manual workflow step for old snapshot commands availability Jun 6, 2024
@dlachaume dlachaume marked this pull request as ready for review June 6, 2024 09:05
@dlachaume dlachaume merged commit ac3eb96 into main Jun 6, 2024
46 of 68 checks passed
@dlachaume dlachaume deleted the damien/remove-old-snapshot-command-compatibility branch June 6, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants