Stabilize namings cardano transactions

[dlachaume]

Content

This PR includes a refactor after the recent implementation of Cardano transactions.

• Cardano transaction commitment has been renamed Cardano transaction snapshot globally in the repository.
• Mithril client CLI command snapshot has been renamed cardano-db. The snapshot command still exists to avoid breaking changes but is deprecated.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)

Issue(s)

Closes #1535

[github-actions]

Test Results

  3 files  ±0   42 suites  ±0   8m 54s ⏱️ +26s
878 tests ±0  878 ✅ ±0  0 💤 ±0  0 ❌ ±0 
967 runs  ±0  967 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c6d72c. ± Comparison against base commit a15369c.

This pull request removes 13 and adds 13 tests. Note that renamed tests count towards both.

mithril-aggregator ‑ services::signed_entity::tests::build_cardano_transactions_commitment_artifact_when_given_cardano_transactions_type
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ application::tests::get_ctx
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ application::tests::get_no_ctx
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ handlers::tests::existing_ctx_commitment_hash
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ handlers::tests::invalid_ctx_commitment_hash
mithril-client ‑ cardano_transaction_client::tests::get_cardano_transactions_commitment
mithril-client ‑ cardano_transaction_client::tests::get_cardano_transactions_commitment_list
mithril-client-cli ‑ commands::snapshot::download::tests::verify_snapshot_signature_should_remove_db_dir_if_messages_mismatch
mithril-client-cli ‑ utils::snapshot::test::check_disk_space_error_should_return_error_if_error_is_not_error_not_enough_space
mithril-client-cli ‑ utils::snapshot::test::check_disk_space_error_should_return_warning_message_if_error_is_not_enough_space
…

mithril-aggregator ‑ services::signed_entity::tests::build_cardano_transactions_snapshot_artifact_when_given_cardano_transactions_type
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ application::tests::get_ctx_snapshot
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ application::tests::get_no_ctx_snapshot
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ handlers::tests::existing_ctx_snapshot_hash
mithril-aggregator-fake::bin/mithril-aggregator-fake ‑ handlers::tests::invalid_ctx_snapshot_hash
mithril-client ‑ cardano_transaction_client::tests::get_cardano_transactions_snapshot
mithril-client ‑ cardano_transaction_client::tests::get_cardano_transactions_snapshot_list
mithril-client-cli ‑ commands::cardano_db::download::tests::verify_cardano_db_signature_should_remove_db_dir_if_messages_mismatch
mithril-client-cli ‑ utils::cardano_db::test::check_disk_space_error_should_return_error_if_error_is_not_error_not_enough_space
mithril-client-cli ‑ utils::cardano_db::test::check_disk_space_error_should_return_warning_message_if_error_is_not_enough_space
…

♻️ This comment has been updated with latest results.

[jpraynaud]

Looks good overall. As seen together, we should probably have the following commands/sub-commands:

• snapshot list => cardano-db snapshot list
• snapshot show => cardano-db snapshot show
• snapshot download => cardano-db download or cardano-db restore

[jpraynaud]

LGTM 👍