Certificate hash in transaction set message #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Alenar
commented
Feb 1, 2024
jpraynaud
approved these changes
Feb 1, 2024
Alenar
force-pushed
the
ensemble/1468/cert_hash_in_tx_set_message
branch
from
8ff9201 to
c8fd485
Compare
dlachaume
approved these changes
Feb 5, 2024
Before we used a simple `From` with an unwrap.
Alenar
force-pushed
the
ensemble/1468/cert_hash_in_tx_set_message
branch
2 times, most recently
from
c598e72 to
62b731c
Compare
…n aggregator http_server
Alenar
force-pushed
the
ensemble/1468/cert_hash_in_tx_set_message
branch
from
62b731c to
66d5053
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR modify the
/proof/cardano-transactionendpoint so it returns the certificate hash on which the proof merkle root relates to.This also means that the
ProverService::compute_transactions_proofs(and the repository behind it) now limit the set of transactions that's they works on. This in order to only works on what have been certified else they could work on transactions that are not in a certificate yet (typically the aggregator is waiting for single signatures).Pre-submit checklist
Issue(s)
Relates to #1468