-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List immutables resilience #1465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I noticed few typos below.
Also I'm OK to fail if no immutable file is found.
Alenar
temporarily deployed
to
testing-preview
January 29, 2024 16:34 — with
GitHub Actions
Inactive
Alenar
force-pushed
the
djo/1450/list_immutables_resilience
branch
2 times, most recently
from
January 29, 2024 16:40
daa419b
to
331f020
Compare
Alenar
temporarily deployed
to
testing-preview
January 29, 2024 16:48 — with
GitHub Actions
Inactive
dlachaume
approved these changes
Jan 30, 2024
* It first find the "immutable" directory (and fails if it can't find it). * It also check the file extension (for either "chunk", "primary" or "secondary").
It will skip the file(s) with the highest number instead of simply skipping the last three files.
Alenar
force-pushed
the
djo/1450/list_immutables_resilience
branch
from
January 30, 2024 11:09
331f020
to
909936e
Compare
Alenar
temporarily deployed
to
testing-preview
January 30, 2024 12:52 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR enhance the immutable files listing, making it more resilient:
Pre-submit checklist
Issue(s)
Closes #1450