-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mithril-common
publication on crates.io
#1372
Merged
jpraynaud
merged 4 commits into
main
from
jpraynaud/fix-build-script-mithril-common-crate
Nov 28, 2023
Merged
Fix mithril-common
publication on crates.io
#1372
jpraynaud
merged 4 commits into
main
from
jpraynaud/fix-build-script-mithril-common-crate
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
approved these changes
Nov 27, 2023
jpraynaud
temporarily deployed
to
testing-preview
November 27, 2023 17:18 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/fix-build-script-mithril-common-crate
branch
from
November 27, 2023 17:59
d901188
to
0152af4
Compare
jpraynaud
temporarily deployed
to
testing-preview
November 27, 2023 18:41 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/fix-build-script-mithril-common-crate
branch
from
November 28, 2023 09:07
0152af4
to
dd421cf
Compare
jpraynaud
temporarily deployed
to
testing-preview
November 28, 2023 09:13 — with
GitHub Actions
Inactive
jpraynaud
deleted the
jpraynaud/fix-build-script-mithril-common-crate
branch
November 28, 2023 11:10
falcucci
pushed a commit
to falcucci/mithril
that referenced
this pull request
Nov 28, 2023
…d/fix-build-script-mithril-common-crate Fix `mithril-common` publication on crates.io
falcucci
pushed a commit
to falcucci/mithril
that referenced
this pull request
Nov 28, 2023
…d/fix-build-script-mithril-common-crate Fix `mithril-common` publication on crates.io
falcucci
pushed a commit
to falcucci/mithril
that referenced
this pull request
Nov 28, 2023
…d/fix-build-script-mithril-common-crate Fix `mithril-common` publication on crates.io
falcucci
pushed a commit
to falcucci/mithril
that referenced
this pull request
Nov 28, 2023
…d/fix-build-script-mithril-common-crate Fix `mithril-common` publication on crates.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the process to publish
mithril-common
on crates.io: the OpenAPI specs file must be published with the package on crates.io so that the build script that computes available API versions.Pre-submit checklist