Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt mithril-client and mithril-common to compile in WASM #1368

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Nov 23, 2023

Content

This PR includes the adaptation of the mithril-common and mithril-client libraries in order to build them in WASM.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1336

Sorry, something went wrong.

Copy link

github-actions bot commented Nov 23, 2023

Test Results

    3 files  ±0    30 suites  ±0   7m 35s ⏱️ - 1m 3s
745 tests ±0  745 ✔️ ±0  0 💤 ±0  0 ±0 
853 runs  ±0  853 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8a93dee. ± Comparison against base commit c609e05.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch from be914c8 to bcd0520 Compare November 23, 2023 15:58
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch 2 times, most recently from 488e33d to 342fc45 Compare November 29, 2023 09:41
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch 4 times, most recently from 52673ea to 954a0c1 Compare November 29, 2023 10:23
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch 2 times, most recently from 40216de to 2f9314d Compare November 29, 2023 10:37
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch 2 times, most recently from c3bdc46 to 9cfd9db Compare December 1, 2023 09:48
@jpraynaud jpraynaud changed the title Release mithril-client WASM library Adapt mithril-client and mithril-common to compile in WASM Dec 1, 2023
@jpraynaud jpraynaud marked this pull request as ready for review December 1, 2023 10:00
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch from 9cfd9db to e38461f Compare December 1, 2023 10:09
mithril-common/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, just the mithril-common crate version that needs to be fixed.

@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch from e38461f to 50c2ea8 Compare December 1, 2023 10:24
@jpraynaud jpraynaud mentioned this pull request Dec 1, 2023
7 tasks
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch from 50c2ea8 to c167bee Compare December 1, 2023 16:14
@jpraynaud jpraynaud force-pushed the ensemble/1336-mithril-client-wasm branch from c167bee to 8a93dee Compare December 5, 2023 09:52
@jpraynaud jpraynaud merged commit e0722cb into main Dec 5, 2023
@jpraynaud jpraynaud deleted the ensemble/1336-mithril-client-wasm branch December 5, 2023 11:24
dlachaume added a commit that referenced this pull request Dec 5, 2023
This PR updates the `default` feature flag of `mithril-client`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants