-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt mithril-client
and mithril-common
to compile in WASM
#1368
Merged
+409
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be914c8
to
bcd0520
Compare
488e33d
to
342fc45
Compare
52673ea
to
954a0c1
Compare
40216de
to
2f9314d
Compare
c3bdc46
to
9cfd9db
Compare
mithril-client
WASM librarymithril-client
and mithril-common
to compile in WASM
9cfd9db
to
e38461f
Compare
dlachaume
reviewed
Dec 1, 2023
dlachaume
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀, just the mithril-common
crate version that needs to be fixed.
e38461f
to
50c2ea8
Compare
ghubertpalo
approved these changes
Dec 1, 2023
7 tasks
50c2ea8
to
c167bee
Compare
Prepare the compilation by putting behind features 'database' and 'process' the code that will not be used in WASM.
c167bee
to
8a93dee
Compare
dlachaume
added a commit
that referenced
this pull request
Dec 5, 2023
This PR updates the `default` feature flag of `mithril-client`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the adaptation of the
mithril-common
andmithril-client
libraries in order to build them in WASM.Pre-submit checklist
Issue(s)
Relates to #1336