-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-7841 Lesson 9 for minting tokens. #45
Conversation
lessons/09-minting/09-minting.ipynb
Outdated
"source": [ | ||
"### Transaction 1. Create the contract on the blockchain\n", | ||
"\n", | ||
"We'll be sending the tokens to holders of [ADA Handles](https://mint.handle.me/), so we need to use the Ada Handles policy ID as the Marlowe roles currency symbol. *If you are not running on `mainnet`, then you'll need to use a different policy ID for the role tokens and you must mint those yourself (or use pre-existing role tokens)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using an admonition here (https://jupyterbook.org/en/stable/content/content-blocks.html)
e.g.
```{warning}
If you are not running on `mainnet`, then you'll need to use a different policy ID for the role tokens and you must mint those yourself (or use pre-existing role tokens).
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jupyter doesn't support "{warning}", so called this out with an icon instead.
lessons/09-minting/09-minting.ipynb
Outdated
"id": "484a9c4a-7ce1-49a2-9550-6d882b9b9e41", | ||
"metadata": {}, | ||
"source": [ | ||
"## Example Marlowe contract: a small airdrop to Ada Handle holders\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving this into a separate notebook since airdrop via Ada Handle isn't minting anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I marked this as optional. I think we'll be reorganizing the starter kit when we migrate lessons to using TS SDK, so we can split this lesson at that time.
lessons/09-minting/09-minting.ipynb
Outdated
"source": [ | ||
"## Design the tokens\n", | ||
"\n", | ||
"Now we create [CIP-25](https://cips.cardano.org/cips/cip25/) metadata for the tokens that we will mint. This has metadata key `721` and consists of the following:\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reader not familiar with CIP-25 might end up thinking 721
is an arbitrary key rather than a reserved label key. Consider adding that it is always 721
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Notebook and video demonstration for minting tokens with Marlowe tools.