-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve simple asset input [LW-9231] #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! TY!
There is one issue cached by sonar, could you please check it and resolve it before merging? |
@szymonmaslowski im not sure which Sonar issue you mean? @pczeglik-iohk do you maybe know what @szymonmaslowski meant with his last comment about a cached Sonar issue? |
Have a look at this PR's report from SonarCloud :) |
4819903
to
fc365ce
Compare
fc365ce
to
e424a0f
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @DominikGuzei
This PR adds additional improvements for the
AmountInput
andSimpleAssetInput
:test-dataid
prop toAmountInput
while not changing the old way of using theid
prop (that might be how it's done in Lace)test-dataid
toSimpleAssetInput
and pass it on toAmountInput
required by the e2e send-flow tests