Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve simple asset input [LW-9231] #60

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

DominikGuzei
Copy link
Member

This PR adds additional improvements for the AmountInput and SimpleAssetInput:

  • allow to pass a specific test-dataid prop to AmountInput while not changing the old way of using the id prop (that might be how it's done in Lace)
  • allow to pass a test-dataid to SimpleAssetInput and pass it on to AmountInput required by the e2e send-flow tests
  • export the asset input data types as discussed here https://github.com/input-output-hk/xsy-wallet/pull/240#discussion_r1795049226

@DominikGuzei DominikGuzei added the enhancement New feature or request label Oct 10, 2024
@DominikGuzei DominikGuzei self-assigned this Oct 10, 2024
Copy link

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! TY!

src/design-system/asset-input/amount-input.component.tsx Outdated Show resolved Hide resolved
@szymonmaslowski
Copy link

There is one issue cached by sonar, could you please check it and resolve it before merging?

@DominikGuzei
Copy link
Member Author

@szymonmaslowski im not sure which Sonar issue you mean? @pczeglik-iohk do you maybe know what @szymonmaslowski meant with his last comment about a cached Sonar issue?

@pczeglik-iohk
Copy link
Collaborator

@szymonmaslowski im not sure which Sonar issue you mean? @pczeglik-iohk do you maybe know what @szymonmaslowski meant with his last comment about a cached Sonar issue?

Have a look at this PR's report from SonarCloud :)

image

@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-improve-simple-asset-input branch from 4819903 to fc365ce Compare October 11, 2024 09:38
@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-improve-simple-asset-input branch from fc365ce to e424a0f Compare October 11, 2024 10:04
Copy link

Copy link
Collaborator

@pczeglik-iohk pczeglik-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DominikGuzei

@DominikGuzei DominikGuzei merged commit 4341255 into main Oct 11, 2024
3 checks passed
@DominikGuzei DominikGuzei deleted the feat/lw-9231-improve-simple-asset-input branch October 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants