Add log lib #3395
Closed
Add log lib #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to have the exact same configuration that jormungandr has right now in the explorer or any other service that we need, keeping things consistent. While re-using the parsing code, naming conventions, etc.
because it's a bit overkill I think
Merged
|
@Enzoc4 Closing it. Feel free to reopen if we really need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the logging config/setup to a new lib/crate.
I'm not fully convinced this is worth it, but it didn't take much work anyway, so I'll leave it here to see what you think. This doesn't really block anything (see below), so there is no need to merge it any time soon.
The motivation would be to use it on #3350 too, but I currently went for the copy-paste option in that branch because otherwise it would be hard to merge, that's why we could leave this for a later date. Maybe even until the next time we want to change anything about the logging.
Also, this probably conflicts with #3358 I guess.