remove graphql address { confirmed_transactions }

it's not really necessary, as getting the confirmed branch and getting it from there creates less api redundancy also, update the schema
input-output-hk · Feb 17, 2021 · 9fee36e · 9fee36e
1 parent 8816369
commit 9fee36e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 52 deletions.
diff --git a/jormungandr/src/explorer/graphql/mod.rs b/jormungandr/src/explorer/graphql/mod.rs
@@ -825,57 +825,6 @@ impl Address {
     fn delegation() -> FieldResult<Pool> {
         Err(ErrorKind::Unimplemented.into())
     }
-
-    async fn confirmed_transactions(
-        &self,
-        first: Option<i32>,
-        last: Option<i32>,
-        before: Option<IndexCursor>,
-        after: Option<IndexCursor>,
-        context: &Context,
-    ) -> FieldResult<TransactionConnection> {
-        let transactions = context
-            .db
-            .get_main_tip()
-            .await
-            .1
-            .state()
-            .transactions_by_address(&self.id)
-            .unwrap_or_else(PersistentSequence::<FragmentId>::new);
-
-        let boundaries = if transactions.len() > 0 {
-            PaginationInterval::Inclusive(InclusivePaginationInterval {
-                lower_bound: 0u64,
-                upper_bound: transactions.len(),
-            })
-        } else {
-            PaginationInterval::Empty
-        };
-
-        let pagination_arguments = PaginationArguments {
-            first,
-            last,
-            before: before.map(u64::from),
-            after: after.map(u64::from),
-        }
-        .validate()?;
-
-        TransactionConnection::new(
-            boundaries,
-            pagination_arguments,
-            |range: PaginationInterval<u64>| match range {
-                PaginationInterval::Empty => vec![],
-                PaginationInterval::Inclusive(range) => (range.lower_bound..=range.upper_bound)
-                    .filter_map(|i| {
-                        transactions
-                            .get(i)
-                            .map(|h| HeaderHash::clone(h))
-                            .map(|h| (TransactionNodeFetchInfo::Id(h), i))
-                    })
-                    .collect(),
-            },
-        )
-    }
 }
 
 struct TaxType(chain_impl_mockchain::rewards::TaxType);

diff --git a/testing/jormungandr-testing-utils/resources/explorer/graphql/schema.graphql b/testing/jormungandr-testing-utils/resources/explorer/graphql/schema.graphql
@@ -2,7 +2,6 @@ type Address {
   """The base32 representation of an address"""
   id: String!
   delegation: Pool!
-  confirmedTransactions(first: Int, last: Int, before: IndexCursor, after: IndexCursor): TransactionConnection!
 }
 
 type BftLeader {
@@ -25,6 +24,7 @@ type Block {
   totalInput: Value!
   totalOutput: Value!
   treasury: Treasury
+  isConfirmed: Boolean!
   branches: [Branch!]!
 }
 
@@ -228,6 +228,7 @@ type Ratio {
 
 type Settings {
   fees: FeeSettings!
+  epochStabilityDepth: String!
 }
 
 scalar Slot