Add expectFailure combinator
#72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
smelc
reviewed
Sep 24, 2024
smelc
approved these changes
Sep 24, 2024
carbolymer
reviewed
Sep 25, 2024
| @@ -140,6 +141,14 @@ failWithCustom cs mdiff msg = liftTest $ mkTest (Left $ H.Failure (getCaller cs) | |||
| failMessage :: MonadTest m => CallStack -> String -> m a | |||
| failMessage cs = failWithCustom cs Nothing | |||
|
|
|||
| -- | Invert the behavior of a property: success becomes failure and vice versa. | |||
| expectFailure :: HasCallStack => H.TestT IO m -> Integration () | |||
| expectFailure prop = GHC.withFrozenCallStack $ do | |||
There was a problem hiding this comment.
It could be useful to be able to investigate the failure and ascertain if that's the expected failure or an accidental one.
carbolymer
approved these changes
Sep 25, 2024
palas
force-pushed
the
add-expect-failure
branch
from
8ea37f3 to
873fcf3
Compare
palas
force-pushed
the
add-expect-failure
branch
from
15d75ef to
4e739de
Compare
Co-authored-by: Mateusz Galazyn <[email protected]>
palas
force-pushed
the
add-expect-failure
branch
from
4e739de to
d9f5c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new combinator that when applied to a property it will invert its behaviour:
This is useful for writing negative tests
See the following PR for an example of usage: IntersectMBO/cardano-cli#910
Based on equivalent QuickCheck combinator: https://hackage.haskell.org/package/QuickCheck-2.15.0.1/docs/Test-QuickCheck.html#v:expectFailure