-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing HasCallStack
to writeGoldenFile, reportGoldenFileMissing, checkAgainstGoldenFile
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, checkAgainstGoldenFile
carbolymer
force-pushed
the
mgalazyn/fix/add-missing-hascallstack
branch
from
May 15, 2024 14:56
b991dad
to
1097bfa
Compare
carbolymer
commented
May 15, 2024
referenceLines <- List.lines <$> H.readFile goldenFile | ||
let difference = getGroupedDiff actualLines referenceLines | ||
case difference of | ||
[] -> pure () | ||
[Both{}] -> pure () | ||
_ -> do | ||
H.note_ $ unlines | ||
[ "Golden test failed against golden file: " <> goldenFile | ||
[ "Golden test failed against the golden file." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path is logged already by H.readFile
above.
Jimbo4350
approved these changes
May 15, 2024
smelc
approved these changes
May 15, 2024
newhoggy
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
HasCallStack
constraint to few functions doing the comparisons between strings or files. This allows for reporting where the failure (the execution of e.g.checkAgainstGoldenFile
) occured. The downside is that the information message about the need to regenerate the files is shown at the failure location instead at the end of the error log. Sample failure after this change: