Add exec variant that allows a negative call #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
reviewed
Jan 11, 2024
src/Hedgehog/Extras/Test/Process.hs
Outdated
| -> String | ||
| -> String | ||
| -> [String] | ||
| -> m (ExitCode, String, String) |
There was a problem hiding this comment.
Can you add a comment what's returned here? I guess stdout and stderr but in what order?
carbolymer
reviewed
Jan 11, 2024
src/Hedgehog/Extras/Test/Process.hs
Outdated
| => ExecConfig | ||
| -> String | ||
| -> [String] | ||
| -> m (ExitCode, String, String) |
There was a problem hiding this comment.
Same as above, a comment explaining Strings in the signature would be great.
newhoggy
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, all functions in
Process.hsassume that the call will succeed: they fail the test if the call fails.This PR adds new variants that do not make this assumption, allowing callers to execute processes that will fail, and handle the exit code, stdout, and stderr themselves.
Context
Needed for IntersectMBO/cardano-node#5634