forked from privacy-scaling-explorations/halo2
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of proving keys and verifying keys #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-ambrona
force-pushed
the
ambrona@smaller-vk
branch
2 times, most recently
from
April 24, 2024 16:00
c776b25
to
3169faa
Compare
iquerejeta
approved these changes
Apr 24, 2024
miguel-ambrona
force-pushed
the
ambrona@smaller-vk
branch
from
April 24, 2024 16:32
3169faa
to
4796ecf
Compare
miguel-ambrona
force-pushed
the
ambrona@smaller-vk
branch
from
April 26, 2024 15:24
238301d
to
392b260
Compare
miguel-ambrona
changed the title
Reduce size of verifying keys
Reduce size of proving keys and verifying keys
Apr 26, 2024
iquerejeta
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - is there an issue or a fix for this in the PSE fork? If yes, could we link it in this PR please?
No, because I think this is more an internal Midnight need. |
iquerejeta
added a commit
that referenced
this pull request
May 8, 2024
* plonk/keygen: add function to compute l polys * plonk/permutation/keygen: add function to compute polys and cosets * plonk: improve size of serialized prover keys Co-authored-by: Iñigo Querejeta Azurmendi <[email protected]> * plonk/keygen: disable complex selectors --------- Co-authored-by: Iñigo Querejeta Azurmendi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For proving keys, on "write" we skip some information which we can easily recompute on "read".
For verifying keys, we disable the complex selector flag globally.