Iquerejeta/pruning #17

iquerejeta · 2024-12-06T14:46:31Z

Pruning of v0.3.0 of halo2:

Implements Plonk generically parametrised by a base field and a polynomial commitment scheme.
Uses the multi-open techniques of Halo2 (presented in their book) in the KZG instantiation
Rewrites trait/interface of the PCS
Removes IPA implementation
Removes implementation of SHPLONK
Removes implementation of shuffle argument

Note: I've rename the structure Assigned to Rational, as IMO it had nothing to do with assigned values. If you think differently, let me know. I can bring that back.

src/arithmetic.rs

src/plonk/vanishing/prover.rs

src/plonk/verifier.rs

privacy-scaling-explorations#342

* Add table, compressed and normal rows count. * Add rows and table rows to cost model. * Ignore unassigned cells if they are multiplied by zero * Some format values are written as "Scalar(0x..)" The hotfix was to change the stripping rules, but this is probably an incorrect implementation of certain traits for one of the curves.

Used the same style as we have in midnight-circuits. Modules are defined with a `mod.rs` file inside the folder, instead of with a file at root level with the same name. I've also created a module for utils and one for the transcript.

src/poly/commitment.rs

davidnevadoc

First pass

src/poly/kzg/params.rs

src/plonk/permutation/verifier.rs

src/poly/query.rs

src/plonk/verifier.rs

miguel-ambrona

This is great! Some would call it a piece of art.

Mind some leftovers of commented code or TODOs. I think David and I marked them all.

src/poly/commitment.rs

src/poly/query.rs

src/poly/kzg/mod.rs

examples/shuffle.rs

src/dev.rs

src/poly.rs

tests/plonk_api.rs

iquerejeta added 7 commits November 29, 2024 10:24

Remove book and halo2. Move everything to parent repo.

f210169

Remove Shuffle

4361bad

Remove IPA

de18a15

Remove SHPLONK

ee29ba0

Remove compressed selectors

3818a52

Temporarily remove examples and benches

a8f0c94

Working version of new polynomial commitment scheme interface.

ea7a14b

miguel-ambrona reviewed Dec 9, 2024

View reviewed changes

src/arithmetic.rs Outdated Show resolved Hide resolved

src/plonk/vanishing/prover.rs Outdated Show resolved Hide resolved

src/plonk/vanishing/prover.rs Outdated Show resolved Hide resolved

src/plonk/verifier.rs Show resolved Hide resolved

Plonk working parametrised only by F and PCS.

5fda15b

iquerejeta force-pushed the iquerejeta/pruning branch from e620943 to 0d9f6ed Compare December 11, 2024 13:11

iquerejeta added 3 commits December 12, 2024 08:47

Bring examples and benches back

522b2ab

Update to halo2curves 0.7.0

c917129

Apply tachyon optimizations

961e7d2

privacy-scaling-explorations#342

iquerejeta force-pushed the iquerejeta/pruning branch from 0d9f6ed to 961e7d2 Compare December 12, 2024 11:46

iquerejeta added 2 commits December 12, 2024 15:51

Cost model update

0092a15

iquerejeta marked this pull request as ready for review December 12, 2024 16:24

iquerejeta added 2 commits December 12, 2024 17:26

Review comments

25ac945

Just moving things around!

a2793a1

Used the same style as we have in midnight-circuits. Modules are defined with a `mod.rs` file inside the folder, instead of with a file at root level with the same name. I've also created a module for utils and one for the transcript.

davidnevadoc reviewed Dec 17, 2024

View reviewed changes

src/poly/commitment.rs Show resolved Hide resolved

davidnevadoc reviewed Dec 17, 2024

View reviewed changes

iquerejeta added 2 commits December 19, 2024 10:44

Remove issue template

dd88760

Review comments

d9ad7a5

miguel-ambrona approved these changes Dec 19, 2024

View reviewed changes

Bring back using the SerdeFormat for keys

428128c

iquerejeta mentioned this pull request Dec 19, 2024

Commit and open without using self #20

Open

iquerejeta added 2 commits December 19, 2024 16:17

Address review comments

ddcb294

Leftover docs

1e2a10a

davidnevadoc approved these changes Dec 20, 2024

View reviewed changes

iquerejeta force-pushed the dev branch from 00ef2ce to 73408a1 Compare December 20, 2024 14:29

iquerejeta merged commit 07c0239 into dev Dec 20, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iquerejeta/pruning #17

Iquerejeta/pruning #17

iquerejeta commented Dec 6, 2024 •

edited

Loading

davidnevadoc left a comment

miguel-ambrona left a comment

Iquerejeta/pruning #17

Iquerejeta/pruning #17

Conversation

iquerejeta commented Dec 6, 2024 • edited Loading

davidnevadoc left a comment

Choose a reason for hiding this comment

miguel-ambrona left a comment

Choose a reason for hiding this comment

iquerejeta commented Dec 6, 2024 •

edited

Loading