Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Changes required for Bridge circuits #16

Closed
wants to merge 149 commits into from

Conversation

iquerejeta
Copy link
Collaborator

Bridge circuits still not passing - do not merge.

adria0 and others added 24 commits May 28, 2024 08:39
- Pending coverage
- Do not rely on random for tests
- Move performance tests to specific test
…ions#344)

fix: random point and scalar generation

Also increased the size of the test MSM from k=4 to k=12.
…#342)

* feat: remove "permutation_product_coset" from "Committed"

* fix: update "h_commitments" part in "vanishing/prover.rs"

* feat: remove the "Constructed" from permutation proving
…ling-explorations#348)

* feat: include "shuffles" in "PinnedConstraintSystem::fmt"

* chore: fix the "plonk_api" test
…s#351)

* patch: add multi-phase related challenge fields within transcript

* chore: fix the "plonk_api" test

* patch: add the Debug attribute
feat!: Use Vectors insead of slices for PI

Instances were being passed as a triple slice of field elements: &[&[&[F]]]
in many functions. It has been replaced for `&[Vec<Vec<F>>]`.
)

* feat: improve the "lookup_any" assertion checks

* feat: add new feature "lookup-any-sanity-checks"

* doc: add comments for new feature checks
…scaling-explorations#358)

* fix: make lookup-any-sanity-checks optional in halo2_proofs

* fix: bad lookup tests only when feature
* bump halo2curves to 0.7

* fix: update compression tests

* fix: update mycircuit, plonk_api and seride tests

---------

Co-authored-by: kilic <[email protected]>
* Implement PartialEq, Eq, Hash for Cell and AssignedCell

* Add table, compressed and normal rows count.

* Add rows and table rows to cost model.

* Ignore unassigned cells if they are multiplied by zero

* Some format values are written as

"Scalar(0x..)"

The hotfix was to change the stripping rules, but this is probably
an incorrect implementation of certain traits for one of the curves.

* Update MWV - this is the smalles version with which I could compile.

* Nits

* Expose constraint (needed to define the types of `Constraints`)

* Remove code coverage token

* Nits
* read_vk does not need to receive the compiled circuit as input

* Default without compress selectors

* Fixed values have changed, because we now use non compressed selectors by default.

* Expose a function to read VKs with compressed selectors.
* Circuit model account for ZK and PIs

* Apply suggestions from code review

Co-authored-by: Miguel Ambrona <[email protected]>

* Warning if PI is dominant factor

---------

Co-authored-by: Miguel Ambrona <[email protected]>
180520d8bccc4392d1e1e210d0f0a2e33dce4708
b86ae99e650f9e04cf6fb787bf9e9e502c0f0ced
3c425cd0a5ed03067250fde1d9bbd76ecc7fc66e
b690f755f3f111bfdedb3df19122d574b9b06ab2
5a510b444c776e88c5e12ae20edc6abc952138d8
56a9a15387b0144a3fc3ec17ed0960c96af2e6c9
@iquerejeta iquerejeta force-pushed the iquerejeta/bridge_circuits branch from b4604d4 to e4e2e55 Compare November 26, 2024 11:21
@iquerejeta
Copy link
Collaborator Author

Closing in favour of #27

@iquerejeta iquerejeta closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.