[WIP] Changes required for Bridge circuits #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: copy symbolic from Plonky3 * feat: copy fibo_air test from Plonky3 * feat: complete p3 frontend PoC * chore: clean up * chore: revert changes in middleware * fix: clippy warnings * feat: add keccak test and fixes - Bring back Rc instead of Box in SymbolicExpression so that expressions built with folding avoid many clones - Rewrite Expression doulbe as `e * 2` instead of `e + e` to avoid exponential cloning in expressions built with folding - When a constraint doesn't use a location, change it to use a selector for usable columns to avoid failing in poisoned rows * chore: clean up * fix: clippy warnings * chore: clean up tests * fix: clippy warnings * fix: remove debug print * chore: comment about transition constraints * chore: extend comment about PrimeField64 impl * fix: merge renamings * chore: add unit tests * fix: clippy complaints * chore: extend unit test * chore: replace no coverage directives * chore: remove no coverage directives * chore: apply feedback from @adria0 * fix: clippy warnings and PCS API update
- Pending coverage - Do not rely on random for tests - Move performance tests to specific test
…ions#344) fix: random point and scalar generation Also increased the size of the test MSM from k=4 to k=12.
…#342) * feat: remove "permutation_product_coset" from "Committed" * fix: update "h_commitments" part in "vanishing/prover.rs" * feat: remove the "Constructed" from permutation proving
…ling-explorations#348) * feat: include "shuffles" in "PinnedConstraintSystem::fmt" * chore: fix the "plonk_api" test
…s#351) * patch: add multi-phase related challenge fields within transcript * chore: fix the "plonk_api" test * patch: add the Debug attribute
feat!: Use Vectors insead of slices for PI Instances were being passed as a triple slice of field elements: &[&[&[F]]] in many functions. It has been replaced for `&[Vec<Vec<F>>]`.
…scaling-explorations#358) * fix: make lookup-any-sanity-checks optional in halo2_proofs * fix: bad lookup tests only when feature
* bump halo2curves to 0.7 * fix: update compression tests * fix: update mycircuit, plonk_api and seride tests --------- Co-authored-by: kilic <[email protected]>
chore: bump to version 0.4
* Implement PartialEq, Eq, Hash for Cell and AssignedCell * Add table, compressed and normal rows count. * Add rows and table rows to cost model. * Ignore unassigned cells if they are multiplied by zero * Some format values are written as "Scalar(0x..)" The hotfix was to change the stripping rules, but this is probably an incorrect implementation of certain traits for one of the curves. * Update MWV - this is the smalles version with which I could compile. * Nits * Expose constraint (needed to define the types of `Constraints`) * Remove code coverage token * Nits
* read_vk does not need to receive the compiled circuit as input * Default without compress selectors * Fixed values have changed, because we now use non compressed selectors by default. * Expose a function to read VKs with compressed selectors.
* Circuit model account for ZK and PIs * Apply suggestions from code review Co-authored-by: Miguel Ambrona <[email protected]> * Warning if PI is dominant factor --------- Co-authored-by: Miguel Ambrona <[email protected]>
180520d8bccc4392d1e1e210d0f0a2e33dce4708 b86ae99e650f9e04cf6fb787bf9e9e502c0f0ced 3c425cd0a5ed03067250fde1d9bbd76ecc7fc66e b690f755f3f111bfdedb3df19122d574b9b06ab2 5a510b444c776e88c5e12ae20edc6abc952138d8 56a9a15387b0144a3fc3ec17ed0960c96af2e6c9
iquerejeta
force-pushed
the
iquerejeta/bridge_circuits
branch
from
b4604d4 to
e4e2e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge circuits still not passing - do not merge.