Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost options #13

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Cost options #13

merged 3 commits into from
Nov 13, 2024

Conversation

iquerejeta
Copy link
Collaborator

@iquerejeta iquerejeta commented Oct 31, 2024 •
edited
Loading

Account for ZK and PIs. Also allow for unknown k when generating cost model.

Closes #12

miguel-ambrona
miguel-ambrona approved these changes Nov 8, 2024
View reviewed changes
Copy link

@miguel-ambrona miguel-ambrona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

halo2_frontend/src/dev/cost_model.rs Show resolved Hide resolved
halo2_frontend/src/dev/cost_model.rs Outdated Show resolved Hide resolved
halo2_frontend/src/dev/cost_model.rs Outdated Show resolved Hide resolved
halo2_frontend/src/dev/cost_model.rs Outdated Show resolved Hide resolved
halo2_frontend/src/dev/cost_model.rs Show resolved Hide resolved
halo2_frontend/src/dev/cost_model.rs Show resolved Hide resolved
@iquerejeta iquerejeta merged commit 00ef2ce into dev Nov 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguel-ambrona miguel-ambrona miguel-ambrona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account for PI and ZK in rows count
2 participants
@iquerejeta @miguel-ambrona