Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_vk does not need to receive the compiled circuit as input #10

Merged

Conversation

iquerejeta
Copy link
Collaborator

@iquerejeta iquerejeta commented Oct 21, 2024

It is not necessary to compile the circuit to generate the VK. With its configuration it is enough.

Closes #11

@iquerejeta iquerejeta force-pushed the iquerejeta/vk_without_circuit branch from 06f929a to b5b0aef Compare October 21, 2024 11:58
Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

halo2_proofs/tests/frontend_backend_split.rs Show resolved Hide resolved
halo2_proofs/src/plonk.rs Show resolved Hide resolved
@iquerejeta iquerejeta merged commit d5bf109 into iquerejeta/midnight-requirements Oct 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants