Combinators for FsPaths and file extensions
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
changed the title
FsPaths and file extensions
jorisdral
commented
Jun 3, 2024
|
Forgot to change the changelog! |
dnadales
approved these changes
Jun 3, 2024
jorisdral
force-pushed
the
jdral/fspath-combinators
branch
from
7d2e95f to
b596c9d
Compare
jorisdral
force-pushed
the
jdral/fspath-combinators
branch
from
b596c9d to
0f03f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #65
This PR includes combinators like
(</>)forFsPaths, which are inspired by the combinators of the same name from thefilepathpackage.I have also created a new issue #68 because the internal representation of
FsPaths seems suboptimal: we often need to linearly traverse the representation when we modify paths.