Move sameError to fs-sim-test
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/move-same-error
branch
from
604205d to
9298640
Compare
amesgen
approved these changes
May 23, 2024
jorisdral
force-pushed
the
jdral/move-same-error
branch
5 times, most recently
from
5e9a674 to
77283a4
Compare
The `sameError` function is only used by the model-based tests in `fs-sim-test` to compare errors that the mocked file system throws against errors that the real file system throws. We do not expect users of the `fs-api`/`fs-sim` packages to use this comparison function themselves, so we have moved to `fs-sim-test` instead. Modules in the `System.FS.IO.Internal` hierarchy are now also public.
jorisdral
force-pushed
the
jdral/move-same-error
branch
from
77283a4 to
b4d47ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sameErrorfunction is only used by the model-based tests infs-sim-testto compare errors that the mocked file system throws against errors that the real file system throws. We do not expect users of thefs-api/fs-simpackages to use this comparison function themselves, so we have moved tofs-sim-testinstead.Modules in the
System.FS.IO.Internalhierarchy are now also public