Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of partial read/write and corruption functions #60

Merged
merged 1 commit into from
May 2, 2024

Conversation

jorisdral
Copy link
Collaborator

@jorisdral jorisdral commented May 2, 2024

I've given some thought to whether I should have added DEPRECATED pragmas for the old functions, but I concluded that it would probably be better to just remove them. ouroboros-consensus and lsm-tree are the only consumers of this package for now

@jorisdral jorisdral requested a review from a team as a code owner May 2, 2024 14:36
@jorisdral jorisdral self-assigned this May 2, 2024
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed that a deprecation cycle doesn't seem necessary 👍

fs-sim/CHANGELOG.md Outdated Show resolved Hide resolved
@jorisdral jorisdral enabled auto-merge May 2, 2024 14:53
@jorisdral jorisdral added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit bd095ae May 2, 2024
18 checks passed
@jorisdral jorisdral deleted the jdral/partial branch May 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants