Simulation and QSM tests for HasBufFS
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
from
390784d to
a0de512
Compare
jorisdral
changed the base branch from
jdral/preadbuf-preadwrite
to
jdral/hTell
jorisdral
changed the base branch from
jdral/hTell
to
jdral/preadbuf-preadwrite
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
6 times, most recently
from
d131d7f to
d967fcc
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
2 times, most recently
from
e7608fd to
3cab82e
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
from
d967fcc to
3ebe6b8
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
2 times, most recently
from
335c12a to
44675ec
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
from
3ebe6b8 to
32c0909
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
from
44675ec to
752bb64
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
6 times, most recently
from
1ac5c8c to
3d7ffb4
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
2 times, most recently
from
ea5c1ae to
62d22c9
Compare
jasagredo
approved these changes
Apr 30, 2024
The function is now no longer constrained to `PrimBase m`, but any `m` for which `PrimState m ~ PrimState IO`.
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
from
62d22c9 to
7da720b
Compare
The simulated version of `HasBufFS` is not yet exposed yet from the public API. This will happen in a later PR.
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite-sim
branch
from
7da720b to
5997881
Compare
dnadales
reviewed
May 1, 2024
| {-# LANGUAGE UnboxedTuples #-} | ||
| {-# LANGUAGE UndecidableInstances #-} | ||
|
|
||
| module System.FS.Sim.Prim ( |
There was a problem hiding this comment.
I'm just wondering if this module deserves an explanation 🤔
There was a problem hiding this comment.
I'll include it in a follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #46