Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not auto-generate keys #23

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

andreabedini
Copy link
Member

This makes not signing the repo the default. If the user passes --sign-with-keys KEYS and the path KEYS does not exist, foliage tells the user to create a set of keys.

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update our scripts in cardano-haskell-packages, but that's fine.

Do I understand correctly that this still builds a secure repository, just with no signatures? I wonder if we should instead build a non-secure repository in this case. Of the three cases:

  1. Secure repo with signatures
  2. Secure repo without signatures
  3. Insecure repo
    It seems to me like 1 and 3 are the reasonable ones and 2 is a bit odd. Not sure I totally understand what's going on though.

@andreabedini andreabedini marked this pull request as draft November 7, 2022 13:25
@andreabedini
Copy link
Member Author

andreabedini commented Nov 7, 2022

I just noticed this still emits {"keyids":[],"threshold":1}. Threshold set to 1 might be a problem. I need to check.

@bgamari
Copy link
Collaborator

bgamari commented Mar 21, 2023

I have merged main into this branch so that we can test it in the head.hackage infrastructure.

@andreabedini
Copy link
Member Author

I have merged main into this branch so that we can test it in the head.hackage infrastructure.

Thank you @bgamari!

@andreabedini
Copy link
Member Author

@michaelpj should we think about merging this? I think CHaP CI will pick up the change and fail (because package.json will be missing the signature and the whole index will change). This would be ok and give us the chance to change the script.

@michaelpj
Copy link
Collaborator

Yep, seems fine. If you're happy with the CLI interface I'm happy.

@michaelpj
Copy link
Collaborator

Might need to change the test fixtures also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants