-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not auto-generate keys #23
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update our scripts in cardano-haskell-packages
, but that's fine.
Do I understand correctly that this still builds a secure repository, just with no signatures? I wonder if we should instead build a non-secure repository in this case. Of the three cases:
- Secure repo with signatures
- Secure repo without signatures
- Insecure repo
It seems to me like 1 and 3 are the reasonable ones and 2 is a bit odd. Not sure I totally understand what's going on though.
I just noticed this still emits |
I have merged |
Thank you @bgamari! |
@michaelpj should we think about merging this? I think CHaP CI will pick up the change and fail (because package.json will be missing the signature and the whole index will change). This would be ok and give us the chance to change the script. |
Yep, seems fine. If you're happy with the CLI interface I'm happy. |
Might need to change the test fixtures also? |
This makes not signing the repo the default. If the user passes
--sign-with-keys KEYS
and the pathKEYS
does not exist, foliage tells the user to create a set of keys.