Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-1072] Remove unused cpu parsing logic #2950

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[DDW-1072] Remove unused cpu parsing logic #2950

wants to merge 3 commits into from

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Apr 7, 2022 •
edited
Loading

This PR removes unused files with cpu parsing logic.

Screenshots

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@szymonmaslowski szymonmaslowski requested review from a team April 7, 2022 07:08
@szymonmaslowski szymonmaslowski self-assigned this Apr 7, 2022
marcin-mazurek
marcin-mazurek suggested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@marcin-mazurek marcin-mazurek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used this utility in my PR: https://github.com/input-output-hk/daedalus/pull/2927/files Please do not remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-mazurek marcin-mazurek marcin-mazurek approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@szymonmaslowski szymonmaslowski

Labels
chore ⏳release-vNext
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonmaslowski @marcin-mazurek