[DDW-703] Undelegate a wallet

[danielmain]

This PR CHANGES.

The undelegation feature is partially completed. It is currently disabled since we needed to cover pending delegation statuses after a wallet is undelegated.

Important to understand: When wallet is undelegated, rewards address is deregistered so rewards cannot be collected. Even though a wallet will be earning rewards for two epochs after it was undelegated, the rewards will go to the Cardano treasury.

Todos

• Reenable the feature
• Update unedelgation wizard to display deposits that will be returned
• Update UI copy
• Update delegation center to display pending delegation preferences for a case when wallet is delegated in an epoch but rewards are going to the treasury.

Screenshots

Testing Checklist

---

Review Checklist

Basics

• PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
• PR is updated to the most recent version of the target branch (and there are no conflicts)
• PR has a good description that summarizes all changes
• PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
  • In English
  • In Japanese
• CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
• Automated tests: All acceptance and unit tests are passing (yarn test)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
• There are no flow errors or warnings (yarn flow:test)
• There are no lint errors or warnings (yarn lint)
• There are no prettier errors or warnings (yarn prettier:check)
• There are no missing translations (running yarn manage:translations produces no changes)
• Text changes are proofread and approved (Jane Wild / Amy Reeve)
• Japanese text changes are proofread and approved (Junko Oda)
• UI changes look good in all themes (Alexander Rukin)
• Storybook works and no stories are broken (yarn storybook)
• In case of dependency changes yarn.lock file is updated

Code Quality

• Important parts of the code are properly commented and documented
• Code is properly typed with flow
• React components are split-up enough to avoid unnecessary re-renderings
• Any code that only works in main process is neatly separated from components

Testing

• New feature/change is covered by acceptance tests
• New feature/change is manually tested and approved by QA team
• All existing acceptance tests are still up-to-date
• New feature/change is covered by Daedalus Testing scenario
• All existing Daedalus Testing scenarios are still up-to-date

After Review

• Merge the PR
• Delete the source branch
• Move the ticket to done column on the YouTrack board
• Update Slack QA thread by marking it with a green checkmark

[danielmain]

This PR is blocked by https://input-output.atlassian.net/browse/ADP-1067

[jonathancross]

This PR is blocked by https://input-output.atlassian.net/browse/ADP-1067

Hi @danielmain - this link is not accessible to the public, can you please give us an update on this critical missing feature? Thanks.

[danielmain]

This PR is blocked by input-output.atlassian.net/browse/ADP-1067

Hi @danielmain - this link is not accessible to the public, can you please give us an update on this critical missing feature? Thanks.

Hi @jonathancross

This is the PR behind: cardano-foundation/cardano-wallet#3119

We need to clarify with the cardano-wallet Team how to integrate it now in Daedalus. By the way, I don't personally see this as a critical feature. You can still re-delegate your wallet to a different pool anytime.

[jonathancross]

I just learned that delegated ADA can still be transferred!?
This was unexpected, but at least I now know delegated coins are not "locked" and un-delegating is not as urgent as I had previously thought. Sorry for the noise I created around this misunderstanding.