Automated Tests to cover Stake Pool Settings and Wallet Currency Display Settings screens

CHANGELOG.md

@@ -92,6 +92,7 @@
 
 ### Chores
 
+- Added tests for currency display settings and stake-pool settings screens ([PR 2622](https://github.com/input-output-hk/daedalus/pull/2622))
 - Removed "Alonzo tada" icon and "Alonzo countdown" screen ([PR 2708](https://github.com/input-output-hk/daedalus/pull/2708))
 - Improved the Daedalus startup by avoiding unnecessary Cardano Node restarts ([PR 2716](https://github.com/input-output-hk/daedalus/pull/2716))
 - Updated README with solution steps for the nix SSL issue ([PR 2727](https://github.com/input-output-hk/daedalus/pull/2727))
@@ -134,6 +135,7 @@
 
 ### Chores
 
+- Added tests for currency display settings and stake-pool settings screens ([PR 2622](https://github.com/input-output-hk/daedalus/pull/2622))
 - Updated `cardano-wallet` to version `2021-09-29` which includes `cardano-node` 1.30.1
 - Updated `trezor-connect` dependency to version `8.2.0` ([PR 2675](https://github.com/input-output-hk/daedalus/pull/2675))
 

package.json

@@ -24,7 +24,7 @@
     "test:e2e:rerun:fail-fast": "yarn cucumber:rerun --require 'tests/setup-e2e.js' --require 'tests/**/e2e/**/*.js' --tags '@e2e and not @skip and not @wip'",
     "test:e2e:watch": "gulp test:e2e:watch",
     "test:e2e:watch:once": "KEEP_APP_AFTER_TESTS=true yarn test:e2e --tags '@e2e and @watch'",
-    "cucumber": "cross-env NODE_ENV=test cucumber-js --require 'tests/setup-common.js' --require-module @babel/register -f json:tests-report/report-data.json -f summary:tests-report/summary.log -f node_modules/cucumber-pretty:tests-report/results.log --format-options '{\"snippetInterface\": \"async-await\"}' -f node_modules/cucumber-pretty --format-options '{\"snippetInterface\": \"async-await\"}' -f rerun:tests/@rerun.txt",
+    "cucumber": "cross-env NODE_ENV=test cucumber-js --require 'tests/setup-common.js' --require-module @babel/register -f json:tests-report/report-data.json -f summary:tests-report/summary.log --format-options '{\"snippetInterface\": \"async-await\"}' -f @cucumber/pretty-formatter --format-options '{\"snippetInterface\": \"async-await\"}' -f rerun:tests/@rerun.txt",
     "cucumber:run": "yarn cucumber tests",
     "cucumber:fail-fast": "yarn cucumber tests --fail-fast",
     "cucumber:rerun": "yarn cucumber tests-report/@rerun.txt",
@@ -81,6 +81,8 @@
     "@babel/preset-flow": "7.16.0",
     "@babel/preset-react": "7.0.0",
     "@babel/register": "7.0.0",
+    "@cucumber/cucumber": "7.3.1",
+    "@cucumber/pretty-formatter": "1.0.0-alpha.1",
     "@dump247/storybook-state": "1.6.1",
     "@storybook/addon-actions": "5.3.14",
     "@storybook/addon-knobs": "5.3.14",
@@ -102,8 +104,6 @@
     "concurrently": "5.3.0",
     "cross-env": "7.0.2",
     "css-loader": "2.0.1",
-    "cucumber": "6.0.5",
-    "cucumber-pretty": "6.0.0",
     "del": "6.0.0",
     "electron-chromedriver": "16.0.0",
     "electron-connect": "0.6.3",
@@ -159,7 +159,7 @@
     "seedrandom": "3.0.5",
     "sinon": "9.2.2",
     "spawn-sync": "2.0.0",
-    "spectron": "14.0.0",
+    "spectron": "15.0.0",
     "style-loader": "0.23.1",
     "stylelint": "13.7.2",
     "stylelint-order": "4.1.0",

tests/addresses/e2e/steps/addresses.js → tests/addresses/e2e/steps/addresses.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, Then, When } from 'cucumber';
+import { Given, Then, When } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { find } from 'lodash';
 import { getVisibleElementsCountForSelector } from '../../../common/e2e/steps/helpers';

tests/app/e2e/steps/about-dialog.js → tests/app/e2e/steps/about-dialog.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import packageJson from '../../../../package.json';
 import type { Daedalus } from '../../../types';

tests/app/e2e/steps/app-version-difference.js → tests/app/e2e/steps/app-version-difference.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { environment } from '../../../../source/main/environment';
 import { getVisibleTextsForSelector } from '../../../common/e2e/steps/helpers';

tests/app/e2e/steps/cardano-node.js → tests/app/e2e/steps/cardano-node.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, Then } from 'cucumber';
+import { Given, Then } from '@cucumber/cucumber';
 import { CardanoNodeStates } from '../../../../source/common/types/cardano-node.types';
 import { getCardanoNodeState, waitForCardanoNodeToExit } from './helpers';
 

tests/app/e2e/steps/daedalus-process.js → tests/app/e2e/steps/daedalus-process.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { waitUntilTextInSelector } from '../../../common/e2e/steps/helpers';
 import { refreshClient, waitForCardanoNodeToExit, waitForDaedalusToExit } from './helpers';
@@ -69,4 +69,4 @@ When(/^I disconnect app$/, function() {
   this.client.execute(() => {
     daedalus.stores.networkStatus._setDisconnected(true);
   });
-});
+});

tests/app/e2e/steps/data-layer-migration.js → tests/app/e2e/steps/data-layer-migration.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import type { Daedalus } from '../../../types';
 
 declare var daedalus: Daedalus;

tests/app/e2e/steps/helpers.js → tests/app/e2e/steps/helpers.ts

@@ -1,5 +1,5 @@
 // @flow
-import { When } from 'cucumber';
+import { When } from '@cucumber/cucumber';
 import { getProcessesByName } from '../../../../source/main/utils/processes';
 import type { Daedalus } from '../../../types';
 

tests/app/e2e/steps/inject-fault.js → tests/app/e2e/steps/inject-fault.ts

@@ -1,5 +1,5 @@
 // @flow
-import { When } from 'cucumber';
+import { When } from '@cucumber/cucumber';
 import type { Daedalus } from '../../../types';
 
 declare var daedalus: Daedalus;
@@ -13,4 +13,4 @@ When(/^I inject fault named "([^"]*)"$/, async function(faultName) {
         throw e;
       });
   }, faultName);
-});
+});

tests/app/e2e/steps/local-time-difference.js → tests/app/e2e/steps/local-time-difference.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, Then } from 'cucumber';
+import { Given, Then } from '@cucumber/cucumber';
 import { expectTextInSelector } from '../../../common/e2e/steps/helpers';
 import type { Daedalus } from '../../../types';
 

tests/app/e2e/steps/node-restart.js → tests/app/e2e/steps/node-restart.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { waitUntilTextInSelector } from '../../../common/e2e/steps/helpers';
 import type { Daedalus } from '../../../types';
 

tests/app/e2e/steps/trouble-connecting-notification.js → tests/app/e2e/steps/trouble-connecting-notification.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Then } from 'cucumber';
+import { Then } from '@cucumber/cucumber';
 import { waitUntilTextInSelector } from '../../../common/e2e/steps/helpers';
 import type { Daedalus } from '../../../types';
 

tests/app/e2e/steps/trouble-syncing-notification.js → tests/app/e2e/steps/trouble-syncing-notification.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Then } from 'cucumber';
+import { Then } from '@cucumber/cucumber';
 import { waitUntilTextInSelector } from '../../../common/e2e/steps/helpers';
 import type { Daedalus } from '../../../types';
 

tests/common/unit/steps/mnemonics-form-validation.steps.js → tests/common/unit/steps/mnemonics-form-validation.steps.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { sampleSize } from 'lodash';
 import sinon from 'sinon';

tests/delegation/e2e/steps/delegation-pending.js → tests/delegation/e2e/steps/delegation-pending.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, Then } from 'cucumber';
+import { Given, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { last } from 'lodash';
 import type { Daedalus } from '../../../types';

tests/delegation/e2e/steps/delegation.js → tests/delegation/e2e/steps/delegation.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, Then } from 'cucumber';
+import { Given, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import BigNumber from 'bignumber.js';
 import { navigateTo } from '../../../navigation/e2e/steps/helpers';

tests/delegation/e2e/steps/rewards.js → tests/delegation/e2e/steps/rewards.ts

@@ -1,6 +1,6 @@
 // @flow
 import fs from 'fs';
-import { When, Then } from 'cucumber';
+import { When, Then } from '@cucumber/cucumber';
 import path from 'path';
 import moment from 'moment';
 import type { Daedalus } from '../../../types';

tests/delegation/e2e/steps/stake-pools.js → tests/delegation/e2e/steps/stake-pools.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import BigNumber from 'bignumber.js/bignumber';
 import { delegationCentreStakingHelper, getStakePoolByRanking } from './helpers';

tests/navigation/e2e/steps/general-settings.js → tests/navigation/e2e/steps/general-settings.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, Then } from 'cucumber';
+import { Given, Then } from '@cucumber/cucumber';
 import { navigateTo, waitUntilUrlEquals } from './helpers';
 
 Given(/^I am on the General Settings "([^"]*)" screen$/, async function(
@@ -12,4 +12,4 @@ Then(/^I should see General Settings "([^"]*)" screen$/, async function(
   screenName
 ) {
   return waitUntilUrlEquals.call(this, `/settings/${screenName}`);
-});
+});

tests/navigation/e2e/steps/sidebar.js → tests/navigation/e2e/steps/sidebar.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { sidebarHelpers } from './helpers';
 import type { Daedalus } from '../../../types';
 

tests/news/e2e/steps/newsfeed-steps.js → tests/news/e2e/steps/newsfeed-steps.ts

@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import { get } from 'lodash';
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import moment from 'moment';
 
 import newsDummyJson from '../documents/dummy-news.json';

tests/paper-wallets/e2e/steps/paper-wallets-certificate.js → tests/paper-wallets/e2e/steps/paper-wallets-certificate.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import path from 'path';
 import { fillOutWalletSendForm } from '../../../wallets/e2e/steps/helpers';

tests/settings/e2e/features/currency-display-settings.feature

@@ -0,0 +1,32 @@
+@e2e
+Feature: Wallet currency display settings
+
+  Background:
+    Given I have completed the basic setup
+    And I have the following wallets:
+      | name        |
+      | Test Wallet |
+
+  Scenario Outline: User selects alternative currency's to display wallet balance
+    Given I am on the General Settings "wallets" screen
+    And I open currency selection dropdown
+    When I select "<currency>" as the selected displayed currency
+    And I am on the "Test Wallet" wallet "summary" screen
+    Then I should see "<ticker>" displayed beside wallet balance
+
+    Examples:
+      | currency  | ticker |
+      | Litecoin  | LTC    |
+      | Stellar   | XLM    |
+
+  Scenario: User hits toggle button to show/not show ada wallet balance in other currency's
+    Given I am on the General Settings "wallets" screen
+    When I toggle the button off to change if I want to see my ada balance in other currency's
+    Then the currency selection box is hidden
+    And I am on the "Test Wallet" wallet "summary" screen
+    Then The wallet summary screen does not show ada balance in other currency's placeholder
+    When I am on the General Settings "wallets" screen
+    And I toggle the button on to change if I want to see my ada balance in other currency's
+    Then the currency selection box is visible
+    And I am on the "Test Wallet" wallet "summary" screen
+    Then The wallet summary screen does show ada balance in other currency's placeholder

tests/settings/e2e/features/stakepool-settings.feature

@@ -0,0 +1,35 @@
+@e2e
+Feature: Stake-pool server settings
+
+  Background:
+    Given I have completed the basic setup
+    And I have the following wallets:
+      | name        |
+      | Test Wallet |
+
+  Scenario: Navigating to Stake-pool settings screen and selecting custom stake-pool server
+    Given I am on the General Settings "stake-pools" screen
+    When I open stake pool server dropdown
+    When I select custom server
+    And The smash server input textBox is visible
+    And And I enter a custom server URL as custom server option
+    And I focus the stake-pool custom server input box submit button and then click it
+    And I see the 'Your changes have been saved' success message
+    And I am on the Delegation "stake-pools" screen
+    Then The custom server I chose earlier is visible on stake-pool screen above stake-pool list and is clickable
+    And I am brought back to the stake-pool server settings screen
+
+  Scenario: Verify stake-pool custom server text box is visible and error message verification
+    Given I am on the General Settings "stake-pools" screen
+    When I open stake pool server dropdown
+    And I select custom server option
+    Then The smash server input textBox is visible
+    And I enter invalid url "www.test" in to the custom server input-box
+    Then Stake-pool custom input box error message "https://" is displayed
+    And I delete values in smash server custom url input box
+    And I enter invalid url "https://test.com/path" in to the custom server input-box
+    Then Stake-pool custom input box error message "protocol and hostname" is displayed
+    And I delete values in smash server custom url input box
+    And I enter invalid server "https://www.google.ie" containing https
+    And I focus the stake-pool custom server input box submit button and then click it
+    Then I see the "This url is not a valid SMASH server" error message displayed

tests/settings/e2e/steps/basic-setup.js → tests/settings/e2e/steps/basic-setup.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given } from 'cucumber';
+import { Given } from '@cucumber/cucumber';
 import { initialSettingsHelpers, migrationHelpers, termsOfUseHelpers } from './helpers';
 
 const { acceptMigration } = migrationHelpers;

tests/settings/e2e/steps/currency-display-settings.ts

@@ -0,0 +1,39 @@
+// @flow
+import { When, Then } from '@cucumber/cucumber';
+import en from '../../../../source/renderer/app/i18n/locales/en-US.json';
+
+const SELECT_CURRENCY_TEXT = en['settings.wallets.currency.selectLabel'];
+
+const CONVERTED_CURRENCY_WALLET_DISPLAY_GENERAL = '//*[@class="WalletSummaryCurrency_currencyRate"]';
+const DISPLAY_BALANCE_OTHER_CURRENCY_TOGGLE_STATUS_OFF = '//*[@class="SimpleSwitch_switch SwitchOverrides_switch"]';
+const DISPLAY_BALANCE_OTHER_CURRENCY_TOGGLE_STATUS_ON = '//*[@class="NormalSwitch_component SimpleSwitch_root SwitchOverrides_root SimpleSwitch_checked SwitchOverrides_checked"]';
+const SELECT_CURRENCY_DROPDOWN = `//*[@label="${SELECT_CURRENCY_TEXT}"]`;
+
+When(/^I open currency selection dropdown$/, function() {
+  return this.client.click(SELECT_CURRENCY_DROPDOWN);
+});
+
+When(/^I select "([^"]*)" as the selected displayed currency$/, function(currency) {
+  return this.client.click(`//*[contains(text(), "${currency}")]`);
+});
+
+Then(/^I should see "([^"]*)" displayed beside wallet balance$/, function(ticker) {
+  return this.client.waitForVisible(`//*[@class="WalletSummaryCurrency_currencyRate" and text()="${ticker}"]`);
+});
+
+When(/^I toggle the button (on|off) to change if I want to see my ada balance in other currency's$/, function(switchStatus) {
+  const selector = switchStatus === 'on'
+    ? DISPLAY_BALANCE_OTHER_CURRENCY_TOGGLE_STATUS_OFF
+    : DISPLAY_BALANCE_OTHER_CURRENCY_TOGGLE_STATUS_ON;
+  return this.waitAndClick(selector);
+});
+
+Then(/^the currency selection box is (hidden|visible)$/, function(state) {
+  const invisibility:boolean = state !== 'visible'
+  return this.client.waitForVisible(SELECT_CURRENCY_DROPDOWN, null, invisibility);
+});
+
+Then(/^The wallet summary screen (does|does not) show ada balance in other currency's placeholder$/, function(status) {
+  const invisible:boolean = status !== 'does'
+  return this.client.waitForVisible(CONVERTED_CURRENCY_WALLET_DISPLAY_GENERAL, null, invisible);
+});

tests/settings/e2e/steps/custom-formats.js → tests/settings/e2e/steps/custom-formats.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import {
   chooseCustomOptionsByValue,

tests/settings/e2e/steps/general-settings.js → tests/settings/e2e/steps/general-settings.ts

@@ -1,5 +1,5 @@
 // @flow
-import { When, Then } from 'cucumber';
+import { When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { camelCase } from 'lodash';
 

tests/settings/e2e/steps/select-language.js → tests/settings/e2e/steps/select-language.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { initialSettingsHelpers } from './helpers';
 import type { Daedalus } from '../../../types';

tests/settings/e2e/steps/settings.js → tests/settings/e2e/steps/settings.ts

@@ -1,5 +1,5 @@
 // @flow
-import { Given, When, Then } from 'cucumber';
+import { Given, When, Then } from '@cucumber/cucumber';
 import { expect } from 'chai';
 import { navigateTo } from '../../../navigation/e2e/steps/helpers';
 import { waitUntilWaletNamesEqual } from '../../../wallets/e2e/steps/helpers';