Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cat-voices): user and wallet model #999

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Conversation

damian-molinski
Copy link
Contributor

Description

  • Introduces concept of Profile and User having multiple profiles. At the moment only one can be passed.
  • WalletHeader and WalletMeta classes to represent information's about wallet that does not come from wallet extension.
  • deletes DummyCardanoWallet

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added do not merge yet PR is not ready to be merged yet review me PR is ready for review dart Pull requests that update Dart code labels Oct 14, 2024
@damian-molinski damian-molinski self-assigned this Oct 14, 2024
@damian-molinski
Copy link
Contributor Author

This is just proposal. We'll need a way to represent wallets that won't come from extension

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

@damian-molinski damian-molinski marked this pull request as ready for review October 15, 2024 08:17
@damian-molinski damian-molinski removed the request for review from minikin October 15, 2024 08:46
…ation/cubits/wallet_link_cubit.dart

Co-authored-by: Dominik Toton <[email protected]>
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit 9acbf86 into main Oct 15, 2024
35 of 37 checks passed
@damian-molinski damian-molinski deleted the refactor/user_model branch October 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants