Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): registration completed screen #996

Merged
merged 24 commits into from
Oct 14, 2024
Merged

feat(cat-voices): registration completed screen #996

merged 24 commits into from
Oct 14, 2024

Conversation

digitalheartxs
Copy link
Contributor

Description

Implement registration completed screen

Related Issue(s)

Closes #948

Screenshots

Screenshot 2024-10-14 at 10 18 52

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@digitalheartxs
feat: Registration completed screen - initial
8ede11f
@digitalheartxs
feat: Registration completed screen - showCloseButton
3a3372c
@digitalheartxs
feat: Registration completed screen - show real data
4876d7b
@digitalheartxs
feat: Registration completed screen - go to discovery
b592a44
@digitalheartxs
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/reg…
3e31a2d 
…istration_completed_screen_948
@digitalheartxs
feat: Registration completed screen - open account
f4e9b2c
@digitalheartxs
feat: Registration completed screen - translations
6a29bc6
@digitalheartxs
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/reg…
5e9125a 
…istration_completed_screen_948

# Conflicts:
#	catalyst_voices/lib/pages/registration/registration_info_panel.dart
@digitalheartxs
feat: Registration completed screen - fix merge
34681a6
@digitalheartxs
feat: Registration completed screen - fix Lint issues
6bcb729
@digitalheartxs
feat: Registration completed screen - better spacing
81456d5
@digitalheartxs digitalheartxs added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Oct 14, 2024
@digitalheartxs digitalheartxs self-assigned this Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

@digitalheartxs digitalheartxs enabled auto-merge (squash) October 14, 2024 11:45
dtscalac
dtscalac approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@digitalheartxs digitalheartxs merged commit a3deb31 into main Oct 14, 2024
35 of 37 checks passed
@digitalheartxs digitalheartxs deleted the feat/registration_completed_screen_948 branch October 14, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac approved these changes

@damian-molinski damian-molinski Awaiting requested review from damian-molinski damian-molinski is a code owner

@minikin minikin Awaiting requested review from minikin

Assignees

@digitalheartxs digitalheartxs

Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Registration completed screen
4 participants
@digitalheartxs @minikin @damian-molinski @dtscalac