Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): keychain and session #995

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Oct 14, 2024

Description

Adds support for keychain which stores the seed phrase and updates session bloc to lock/unlock the session.

Next PRs will:

  • add support for lock/unlock
  • add support for session expiration (currently once unlocked it stays unlocked)

Clicking on these links will put the application in different states with mocked data:

Screenshot 2024-10-14 at 08 40 08

  /// Temporary implementation for testing purposes.
  User get _dummyUser => const User(name: 'Account');

  /// Temporary implementation for testing purposes.
  SeedPhrase get _dummySeedPhrase => SeedPhrase.fromMnemonic(
        'few loyal swift champion rug peace dinosaur'
        ' erase bacon tone install universe',
      );

  /// Temporary implementation for testing purposes.
  LockFactor get _dummyUnlockFactor => const PasswordLockFactor('Test1234');

Related Issue(s)

Refers #813

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Oct 14, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 14, 2024
@dtscalac dtscalac self-assigned this Oct 14, 2024
@dtscalac dtscalac requested a review from minikin as a code owner October 14, 2024 06:29
@dtscalac dtscalac removed the request for review from minikin October 14, 2024 06:29
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

@dtscalac dtscalac changed the title feat(vat-voices): keychain and session feat(cat-voices): keychain and session Oct 14, 2024
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dtscalac dtscalac merged commit 15f6013 into main Oct 14, 2024
35 of 37 checks passed
@dtscalac dtscalac deleted the feat/keychain-key-derivation branch October 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants