Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): restore unlock password #994

Merged
merged 5 commits into from
Oct 14, 2024
Merged

feat(cat-voices): restore unlock password #994

merged 5 commits into from
Oct 14, 2024

Conversation

damian-molinski
Copy link
Contributor

Description

  • Adds recovery unlock password steps
  • Extracts common password widgets

Related Issue(s)

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review dart Pull requests that update Dart code labels Oct 11, 2024
@damian-molinski damian-molinski self-assigned this Oct 11, 2024
@damian-molinski damian-molinski removed the request for review from minikin October 11, 2024 13:25
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

dtscalac
dtscalac approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

digitalheartxs
digitalheartxs approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@digitalheartxs digitalheartxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@damian-molinski damian-molinski merged commit f789198 into main Oct 14, 2024
36 of 38 checks passed
@damian-molinski damian-molinski deleted the feat/restore_unlock_password branch October 14, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalheartxs digitalheartxs digitalheartxs approved these changes

@dtscalac dtscalac dtscalac approved these changes

Assignees

@damian-molinski damian-molinski

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Unlock Password 🛠️ [TASK] : Unlock Password Instructions
3 participants
@damian-molinski @dtscalac @digitalheartxs