Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update voting protocol definition and the jormnugandr tx spec #993

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

Description

Updated the voting protocol with the jormungandr tx specifications.
Provided missing parts.

Related Issue(s)

input-output-hk/catalyst-libs#58

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 11, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes looks good to me, but a question arise when I reread the doc.

Voting committee - a special trusted entity, which perform tally process and revealing the results of the tallying. Such committee consists of the 1 person.
Election public key - committees generated public key, which is shared across all voters and used for vote's encryption and tallying processes.
  1. Is the Voting committee consist of multiple entities? because it states in Election public key "committees"

@Mr-Leshiy
Copy link
Contributor Author

Mr-Leshiy commented Oct 14, 2024

@bkioshn Thank you for the question.
Let me clarify on this. In general it could be multiple entities for voting committee (right now for Jormungandr we are using only one) and they must generate a shared one public key, which represents their all. The matter how they generate this public key it's another story and could be done with some sort of DKG algorithm. For this specific voting protocol it's just important to have such public key.

Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin enabled auto-merge (squash) October 14, 2024 10:47
@minikin minikin merged commit 192345f into main Oct 14, 2024
37 checks passed
@minikin minikin deleted the fix/voting-docs branch October 14, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants