Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): mocked recover wallet #990

Merged
merged 13 commits into from
Oct 11, 2024
Merged

feat(cat-voices): mocked recover wallet #990

merged 13 commits into from
Oct 11, 2024

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Oct 10, 2024 •
edited
Loading

Description

  • Restored account AccountDetailsPanel. This is panel where user can see Success or Failure from restoration
  • Extract common WalletConnectionStatus and WalletSummary widgets from WalletDetailsPanel
  • Fix SeedPhraseField scrollbar crash
  • In kDebugMode words is pre-filed
  • Introduce DummyCardanoWallet which implements CardanoWallet. This should be only used as temp replacement for real implementation.

Related Issue(s)

Part of #954

Demo

recover_result_panel.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Oct 10, 2024
@damian-molinski damian-molinski self-assigned this Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

@damian-molinski damian-molinski changed the title feat(cat-voices): recover wallet 954 feat(cat-voices): mocked recover wallet Oct 10, 2024
@damian-molinski damian-molinski marked this pull request as ready for review October 10, 2024 14:07
@damian-molinski damian-molinski removed the request for review from minikin October 10, 2024 14:07
@damian-molinski damian-molinski enabled auto-merge (squash) October 11, 2024 08:03
dtscalac
dtscalac approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit 43997ae into main Oct 11, 2024
35 of 37 checks passed
@damian-molinski damian-molinski deleted the feat/recover_wallet_954 branch October 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac approved these changes

@digitalheartxs digitalheartxs Awaiting requested review from digitalheartxs

Assignees

@damian-molinski damian-molinski

Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
M4: Proposal Submission & Commentary ...
Development

Successfully merging this pull request may close these issues.
2 participants
@damian-molinski @dtscalac