Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cat-gateway as the container entrypoint #988

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

benbooth493
Copy link
Contributor

@benbooth493 benbooth493 commented Oct 10, 2024

Description

Set the container entrypoint to cat-gateway binary.

Related Issue(s)

#50

Description of Changes

Remove entry.sh from the container and set the entrypoint as the cat-gateway binary.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

@saibatizoku saibatizoku force-pushed the 50-task-package-cat-gateway branch from 0ae208a to fb32b9c Compare October 10, 2024 13:20
saibatizoku
saibatizoku previously approved these changes Oct 10, 2024
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although it seems to me like the commented lines should be removed if they will not be used.

Copy link
Contributor Author

@benbooth493 benbooth493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed commented out code as requested

@benbooth493 benbooth493 merged commit c77bdcd into main Oct 11, 2024
10 of 11 checks passed
@benbooth493 benbooth493 deleted the 50-task-package-cat-gateway branch October 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants