Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cat-voices): smoke integration test #898

Merged
merged 23 commits into from
Oct 30, 2024
Merged

test(cat-voices): smoke integration test #898

merged 23 commits into from
Oct 30, 2024

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Sep 27, 2024 •
edited
Loading

Description

This PR adds a simple integration test for voices

@kukkok3 kukkok3 self-assigned this Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 336/336}$ | ${\color{red}Fail: 0/336}$ |

@minikin minikin added the draft Draft label Oct 14, 2024
@kukkok3 kukkok3 removed the draft Draft label Oct 29, 2024
@kukkok3 kukkok3 linked an issue Oct 29, 2024 that may be closed by this pull request
🛠️ [TASK] : Develop simple integration test for catalyst voices #786
Closed
@kukkok3 kukkok3 requested a review from dtscalac October 29, 2024 15:25
@kukkok3 kukkok3 marked this pull request as ready for review October 29, 2024 15:25
@kukkok3 kukkok3 requested a review from minikin as a code owner October 29, 2024 15:25
@kukkok3 kukkok3 requested review from emiride and oldGreg5 October 29, 2024 15:25
@kukkok3 kukkok3 enabled auto-merge (squash) October 29, 2024 15:26
dtscalac
dtscalac approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kukkok3 would it be possible to update the PR description to remove unused boilerplate fields?

@kukkok3 kukkok3 merged commit 6fd3020 into main Oct 30, 2024
39 checks passed
@kukkok3 kukkok3 deleted the test/voices-main-integration-test branch October 30, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac approved these changes

@minikin minikin Awaiting requested review from minikin

@emiride emiride Awaiting requested review from emiride

@oldGreg5 oldGreg5 Awaiting requested review from oldGreg5

Assignees

@kukkok3 kukkok3

Labels
None yet
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Develop simple integration test for catalyst voices
4 participants
@kukkok3 @dtscalac @minikin @stevenj