Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): My account, modals #894

Merged
merged 17 commits into from
Sep 30, 2024
Merged

feat(cat-voices): My account, modals #894

merged 17 commits into from
Sep 30, 2024

Conversation

digitalheartxs
Copy link
Contributor

@digitalheartxs digitalheartxs commented Sep 26, 2024 •
edited
Loading

Description

Modals in My account

Related Issue(s)

Closes #822

Screenshots

modals.mp4

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@digitalheartxs digitalheartxs added the draft Draft label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

damian-molinski
damian-molinski reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract all strings into l10n. It does not seems it will be mocked

catalyst_voices/lib/pages/account/keychain_deleted_dialog.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/pages/account/keychain_deleted_dialog.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/pages/account/delete_keychain_dialog.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/pages/account/delete_keychain_dialog.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/pages/account/delete_keychain_dialog.dart Outdated Show resolved Hide resolved
@digitalheartxs
feat: My account, modals, remove unnecessary comment
386ff77
@digitalheartxs
feat: My account, modals, extract translations for delete_keychain_di…
c0c7f9b 
…alog.dart
@digitalheartxs
feat: My account, modals, extract translations for keychain_deleted_d…
0229234 
…ialog.dart
@digitalheartxs
feat: My account, modals, extract _onRemoveKeychainTap
11276e6
@digitalheartxs
feat: My account, modals, pass onDeleteKeychain callback
24905c0
@digitalheartxs
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/my_…
9e2814d 
…account_822_modals

# Conflicts:
#	catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/l10n/intl_en.arb
@digitalheartxs
feat: My account, modals, merge changes
921a8bc
@digitalheartxs
feat: My account, modals, refactor base dialogs
50974e4
@digitalheartxs digitalheartxs added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code and removed draft Draft labels Sep 27, 2024
damian-molinski
damian-molinski approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@digitalheartxs digitalheartxs merged commit f637df2 into main Sep 30, 2024
23 of 26 checks passed
@digitalheartxs digitalheartxs deleted the feat/my_account_822_modals branch September 30, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@minikin minikin Awaiting requested review from minikin

@dtscalac dtscalac Awaiting requested review from dtscalac dtscalac is a code owner

Assignees

@digitalheartxs digitalheartxs

Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : My account
4 participants
@digitalheartxs @damian-molinski @dtscalac @stevenj