Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cat-ci version to 3.1.13 #592

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Conversation

SotaTek-DuyLe
Copy link
Contributor

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Test Report | ${\color{lightgreen}Pass: 91/91}$ | ${\color{red}Fail: 0/91}$ |

kukkok3
kukkok3 previously approved these changes Jul 4, 2024
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3
Copy link
Contributor

kukkok3 commented Jul 4, 2024

The error you are getting in CI means the cargo deny in your branch is different than the cargo deny in CI From what I can see there where some changes to cargo deny in this release Basically the deny.toml in catalyst-voices needs to be the same than the one in CI

Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 enabled auto-merge (squash) July 5, 2024 06:12
@kukkok3 kukkok3 merged commit 9e0e14a into main Jul 5, 2024
19 of 20 checks passed
@kukkok3 kukkok3 deleted the feat/cat-ci-version-to-3.1.13 branch July 5, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

First
2 participants