Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hook for schemathesis tests #513

Merged
merged 8 commits into from
May 29, 2024

Conversation

SotaTek-DuyLe
Copy link
Contributor

@SotaTek-DuyLe SotaTek-DuyLe commented May 25, 2024

Description

  • Add hook to modify schema so that schemathesis tries to do a POST on an endpoint that's only a GET and vice versa (PUT, PATCH, DELETE as well)

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@SotaTek-DuyLe SotaTek-DuyLe requested a review from kukkok3 May 27, 2024 10:12
kukkok3
kukkok3 previously approved these changes May 28, 2024
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 assigned kukkok3 and SotaTek-DuyLe and unassigned kukkok3 May 28, 2024
Copy link
Contributor

github-actions bot commented May 29, 2024

Test Report | ${\color{lightgreen}Pass: 125/127}$ | ${\color{red}Fail: 2/127}$ |

@SotaTek-DuyLe SotaTek-DuyLe requested a review from kukkok3 May 29, 2024 14:04
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit c8427e5 into main May 29, 2024
30 checks passed
@kukkok3 kukkok3 deleted the feat/489-add-tests-for-http-methods branch May 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add tests for HTTP methods First
2 participants