Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser installers #428

Merged
merged 8 commits into from
Apr 16, 2024
Merged

fix: browser installers #428

merged 8 commits into from
Apr 16, 2024

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Apr 16, 2024

Description

This PR adds support for installing browsers on arm64 architectures

Description of Changes

When arm64 architecture is detected:

  • Chromium is installed instead of Chrome
  • Unstable version of Firefox for amd64 is installed from the unstable repo
  • Installing Edge is skipped since there is no support for Edge for linux/amd64

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 changed the title Fix: browser installers fix: browser installers Apr 16, 2024
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Test Report | ${\color{lightgreen}Pass: 8/8}$ | ${\color{red}Fail: 0/8}$ |

@kukkok3 kukkok3 linked an issue Apr 16, 2024 that may be closed by this pull request
2 tasks
@kukkok3 kukkok3 marked this pull request as ready for review April 16, 2024 12:18
@kukkok3 kukkok3 requested a review from minikin as a code owner April 16, 2024 12:18
@minikin minikin enabled auto-merge (squash) April 16, 2024 12:18
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 self-assigned this Apr 16, 2024
@minikin minikin merged commit ec593e0 into main Apr 16, 2024
22 checks passed
@minikin minikin deleted the fix/browser-installers branch April 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Installing browsers fails on mac
2 participants