Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize media query usage to avoid redundant rebuilds #398

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Apr 9, 2024

Description

Optimizes usage of MediaQuery to subscribe to only required changes in MediaQuery.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac requested a review from minikin as a code owner April 9, 2024 12:04
@dtscalac dtscalac self-assigned this Apr 9, 2024
@dtscalac dtscalac added the review me PR is ready for review label Apr 9, 2024
@dtscalac dtscalac changed the title perf: optimize media query usage to avoid redundant rebuilds perf: Optimize media query usage to avoid redundant rebuilds Apr 9, 2024
@dtscalac dtscalac requested a review from coire1 April 9, 2024 12:04
@minikin minikin enabled auto-merge (squash) April 9, 2024 12:11
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Test Report | ${\color{lightgreen}Pass: 32/33}$ | ${\color{red}Fail: 1/33}$ |

@minikin minikin merged commit 0f4afb3 into main Apr 9, 2024
34 checks passed
@minikin minikin deleted the feat/optimize-media-query-usage branch April 9, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants