Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(catalyst_voices): fixes Earthfile and adds publish target #391

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jmgilman
Copy link
Collaborator

@jmgilman jmgilman commented Apr 8, 2024

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@jmgilman jmgilman requested a review from minikin as a code owner April 8, 2024 14:14
@minikin minikin enabled auto-merge (squash) April 8, 2024 14:17
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Test Report | ${\color{lightgreen}Pass: 32/33}$ | ${\color{red}Fail: 1/33}$ |

@minikin minikin merged commit b582ef2 into main Apr 8, 2024
21 checks passed
@minikin minikin deleted the fix-voices-earthly branch April 8, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

First
2 participants